[App Config] Update Response Output for Label for Configuration Setting #27622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhanh-phan
requested review from
bterlson,
xirzec,
jeremymeng and
HarshaNalluru
as code owners
github-actions
bot
added
the
App Configuration
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -72,7 +72,7 @@ export type ConfigurationSetting<T extends string | FeatureFlagValue | SecretRef | |||
| export interface ConfigurationSettingId { | |||
| etag?: string; | |||
| key: string; | |||
| label?: string; | |||
| label?: string | null; | |||
minhanh-phan
changed the title
Eskibear
reviewed
Nov 2, 2023
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
xirzec
approved these changes
Nov 2, 2023
HarshaNalluru
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
app-configuration
Issues associated with this PR
#27607
Describe the problem that is addressed by this PR
The service returns
nullfor configuration settings without label, and our type specifies that label is an optional property of type string. The PR changes the response type to fromlabel: nulltolabel: undefinedandcontentType: nulltocontentType: undefinedWhat are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists