Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the missing export for KeyCredential in ts http runtime lib #27631

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Nov 2, 2023

Adding the missing export for KeyCredential for ts http runtime lib

@MaryGao MaryGao changed the title Adding the missing export for KeyCredential for ts http runtime lib Adding the missing export for KeyCredential in ts http runtime lib Nov 3, 2023
@MaryGao MaryGao marked this pull request as ready for review November 3, 2023 04:36
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you help check if there's any test regarding this ?

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

typespec-ts-http-runtime

@MaryGao MaryGao merged commit 1eef2c9 into Azure:main Nov 3, 2023
16 checks passed
@xirzec
Copy link
Member

xirzec commented Nov 3, 2023

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants