Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Communication Rooms Readme Issue And Push Recordings In Communication Library #28607

Merged
merged 23 commits into from
Jun 3, 2024

Conversation

v-weiyding
Copy link
Member

Fixes #27565

@joheredi, @mayurid, @alexokun for notification.

@v-weiyding v-weiyding force-pushed the fix-issue#27565 branch 4 times, most recently from 6f00505 to 02104bf Compare February 19, 2024 08:00
@v-weiyding v-weiyding marked this pull request as ready for review February 19, 2024 08:17
@v-xuto
Copy link
Member

v-xuto commented Feb 19, 2024

@joheredi, @mayurid, @alexokun Could you help review this PR and merge it if it looks good?

Copy link

Hi @v-weiyding. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Apr 26, 2024
Copy link

github-actions bot commented May 3, 2024

Hi @v-weiyding. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 3, 2024
@v-jiaodi v-jiaodi reopened this May 27, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label May 27, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kazrael2119
Copy link
Contributor

this commit ix communication-message-rest ci test error is just update the recording to fix following ci error
image

@kazrael2119 kazrael2119 requested a review from yogeshmo as a code owner May 30, 2024 08:54
@kazrael2119
Copy link
Contributor

kazrael2119 commented May 30, 2024

for this commit fix communication-email ci test error is to fix
image

@kazrael2119
Copy link
Contributor

kazrael2119 commented May 30, 2024

for this commit fix communication-job-router ci test error is to fix
image

@kazrael2119
Copy link
Contributor

for this commit fix communication-job-router-rest ci test error is to fix
image

@kazrael2119
Copy link
Contributor

this commit
fix communication-chat ci test error is to fix
image

Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha qiaozha requested a review from xirzec May 31, 2024 09:28
@qiaozha
Copy link
Member

qiaozha commented May 31, 2024

@xirzec since this pr is updating communication data plane libraries, do you have any concerns here?

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor note where I think we could avoid some test assertion changes by removing a central sanitizer like in other packages.

Overall, the changes look good and I'm excited to get more recordings out of the repo. @akania @DominikMe @allchiang-msft any thoughts/feedback before this gets merged?

@kazrael2119 kazrael2119 changed the title Fix Communication Rooms Readme Issue Fix Communication Rooms Readme Issue And Push Recordings In Communication Library Jun 3, 2024
@qiaozha
Copy link
Member

qiaozha commented Jun 3, 2024

I will merge this PR, @akania @DominikMe @allchiang-msft feel free to let me know if you have any concerns.

@qiaozha qiaozha merged commit 25c7a3a into Azure:main Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communication Rooms Readme Issue
7 participants