Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
Nightly test failures
Describe the problem that is addressed by this PR
Our nightly tests started failing with a
TypeError: Descriptor for property generatePluginConfiguration is non-configurable and non-writable
error.I'm far from an expert here, but I believe the error is due to ESModules being
immutable, whereas CJS Modules are mutable.
Wrapping the stubbable / mockable object is a reasonable workaround to keep
tests green regardless of whether they get run as ESM or CJS
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Deleting the tests is an option, or an integration test. Neither seem to fit the
bill here. Once we have credentials migrated over we may be able to delete some
of the unit tests and rely on recorded tests to test the various scenarios. But
we are not there yet.
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists