Skip to content

[Schema Registry] Update JsonSchemaSerializer Class Name #29978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

minhanh-phan
Copy link
Member

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

Prepare GA release for schema registry & schema registry Json schema serializer. Change class name from JsonSerializer to JsonSchemaSerializer

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@minhanh-phan minhanh-phan marked this pull request as ready for review June 17, 2024 19:26
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 API changes make sense to me, I only skimmed the sample changes

Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
@minhanh-phan minhanh-phan merged commit 74b40a2 into Azure:main Jun 17, 2024
@minhanh-phan minhanh-phan deleted the schemaregistry/update branch June 17, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants