Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] set package version back to 3.0.0 #30090

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Jun 18, 2024

to fix broken nightly pipelines where we update @azure package versions to
nightly versions and dependency versions to a range for their nightly versions.
Version ^3.0.0 would not get updated because of the following check in
set-dev.js then rush install would fail to find matching one and report error.

if (semver.eq(parsedDepMinVersion, parsedPackageVersion)) {

to fix broken nightlies pipelines where we update `@azure` package versions to
nightly versions and dependency versions to a range for their nightly versions.
Versino `^3.0.0` would not get updated because of the following chech in
`set-dev.js` then `rush install` would fail to find matching one and report error.

https://github.com/Azure/azure-sdk-for-js/blob/9488fe4bd780306e2f00eaa1509eba20982215f4/eng/tools/versioning/set-dev.js#L80
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremymeng
Copy link
Member Author

cosmos db pipeline failures unrelated and already appeared in earlier runs. Going to override.

@jeremymeng
Copy link
Member Author

/check-enforcer override

@jeremymeng jeremymeng merged commit 57d1bd9 into Azure:main Jun 18, 2024
59 of 62 checks passed
@jeremymeng jeremymeng deleted the engsys/eslint-plugin-3.1.0 branch June 18, 2024 18:36
@KarishmaGhiya
Copy link
Member

Thank you for this PR @jeremymeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants