[mgmt] standbypool release #31087
[mgmt] standbypool release #31087
Conversation
kazrael2119
requested review from
qiaozha,
MaryGao,
a team,
ckairen and
jeremymeng
as code owners
github-actions
bot
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| System = "system", | ||
| User = "user", | ||
| UserSystem = "user,system" | ||
| "user,system" = "user,system", |
There was a problem hiding this comment.
this is from arm definition and it's readonly in response https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L226-L241
/**
* The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is "user,system"
*/
union Origin {
/** Indicates the operation is initiated by a user. */
user: "user",
/** Indicates the operation is initiated by a system. */
system: "system",
/** Indicates the operation is initiated by a user or system. */
`user,system`: "user,system",
string,
}
| } | ||
|
|
||
| // @public | ||
| export interface StandbyContainerGroupPoolResourceUpdateProperties { | ||
| containerGroupProperties?: ContainerGroupPropertiesUpdate; | ||
| elasticityProfile?: StandbyContainerGroupPoolElasticityProfileUpdate; | ||
| containerGroupProperties?: ContainerGroupProperties; |
| } | ||
|
|
||
| // @public | ||
| export type Versions = "2023-12-01-preview" | "2024-03-01-preview" | "2024-03-01"; |
| ); | ||
| }); | ||
|
|
||
| afterEach(async function () { |
There was a problem hiding this comment.
is this easy to add test case? if yes could you add for CURD.
| @@ -4,10 +4,8 @@ This package contains an isomorphic SDK (runs both in Node.js and in browsers) f | |||
|
|
|||
|
|
|||
|
|
|||
| [Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/standbypool/arm-standbypool) | | |||
| [Package (NPM)](https://www.npmjs.com/package/@azure/arm-standbypool) | | |||
There was a problem hiding this comment.
why source code link is removed?
| [Package (NPM)](https://www.npmjs.com/package/@azure/arm-standbypool) | | ||
| [API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-standbypool?view=azure-node-preview) | | ||
| [Samples](https://github.com/Azure-Samples/azure-samples-js-management) |
There was a problem hiding this comment.
why samples link is removed?
|
|
||
| ### Features Added | ||
|
|
||
| The package of @azure/arm-standbypool is using our next generation design principles. To learn more, please refer to our documentation [Quick Start](https://aka.ms/azsdk/js/mgmt/quickstart ). | ||
| The package of @azure/arm-standbypool is using our next generation design principles. To learn more, please refer to our documentation [Quick Start](https://aka.ms/azsdk/js/mgmt/quickstart). |
There was a problem hiding this comment.
TODO: Need to confirm the changelog here.
do we finalize the GA changelog yet?
There was a problem hiding this comment.
no, the GA changelog is from hlc
There was a problem hiding this comment.
for preview tsp packages the log is Initial release of the Azure MongoCluster package
need confirm the log with tsp ga packages.
https://github.com/Azure/sdk-release-request/issues/5443
swagger pr: Azure/azure-rest-api-specs#30550