-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Dynamic Matrix Config #31542
Using Dynamic Matrix Config #31542
Conversation
/azp run js - pullrequest |
/azp run js - pullrequest |
/azp run js - pullrequest |
/azp run js - pullrequest |
… and no matter what I do AZDO is refusing to queue the build
/azp run js - matrix-pullrequest |
/azp run js - matrix-pullrequest |
1 similar comment
/azp run js - matrix-pullrequest |
} | ||
|
||
# if we know this is the matrix for our file, we should now see if there is a custom matrix config for the package | ||
$matrixConfigList = GetValueSafelyFrom-Yaml $content @("extends", "parameters", "MatrixConfigs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also handle values behind devops template conditionals? e.g. https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/tests.yml#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not currently.
As I mentioned I was wondering if the generation complexity would be high, but the changes necessary are so small that I think it's very reasonable. I think if you add more examples on inline comments of an inputted matrix set to an outputted matrix set, with the actual package name additions then it will be very approachable to maintain/update going forwards. |
Executing! |
…akes 0 sense that it's returning an error. I hate powershell so much
…tually invoking the script
/azp run js - matrix-pullrequest |
Azure Pipelines successfully started running 1 pipeline(s). |
All the conversations in this PR ended up being commited in Azure/azure-sdk-tools#9281. Closing this PR in favor of #31420 in this repo. |
I've been thinking a lot about how we can abstract away both the package distribution as well as when specific packages have restrictions on what matrix they run.
This PR updates
generate-job-matrix.yml
with a possible solution. (A lot of the powershell is not fully filled out as this is just a proto)We will:
This way we will be able to generate multiple platform matrixes while also allowing the custom selections from the users.