[OpenAI] Precise Typechecking #31786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
a team,
glharper and
minhanh-phan
as code owners
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Nov 16, 2024
minhanh-phan
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind the scene, TSHY rewrites tsconfig.json to build the source code of the library but it ignores tests and samples. This PR breaks the monolith tsconfig.json into three ones, one for building the source, one for the tests, and one for the samples. It utilizes Project References to create a TS project each. This setup makes sure type errors are adequately caught in each of those projects.
Additionally, the PR disables rolling up d.ts files and fixes a type error in tests.