Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Improve EventPosition class #3182

Merged
merged 2 commits into from
May 24, 2019
Merged

[Event Hubs] Improve EventPosition class #3182

merged 2 commits into from
May 24, 2019

Conversation

ShivangiReja
Copy link
Member

As per the API proposal in #2718 (comment), Improve EventPosition class.

This PR updates the following:

  • Move getExpression() out of EventPosition class.
  • change startOfStream -> firstAvailableEvent and endOfStream -> newEventsOnly
  • firstAvailableEvent and endOfStream return as a static properties on the class.

@ShivangiReja ShivangiReja added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 24, 2019
@ShivangiReja ShivangiReja requested a review from ramya-rao-a May 24, 2019 00:56
@ShivangiReja ShivangiReja self-assigned this May 24, 2019
@ramya-rao-a
Copy link
Contributor

This fixes #3174

@ramya-rao-a ramya-rao-a merged commit 828f637 into Azure:event-hubs-track2 May 24, 2019
@ramya-rao-a ramya-rao-a mentioned this pull request May 24, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees

@ShivangiReja ShivangiReja

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivangiReja @ramya-rao-a