[@azure/eventgrid] - Release V5.10.0 Jan 2025 #32441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
xirzec
approved these changes
Jan 21, 2025
3 tasks
jeremymeng
added a commit
that referenced
this pull request
Feb 20, 2025
### Packages impacted by this PR `@Azure/eventgrid` ### Issues associated with this PR Azure/azure-rest-api-specs#32013 Azure/azure-rest-api-specs#32548 ### Describe the problem that is addressed by this PR This PR includes the following changes - properties added to `AcsMessageMediaContent` - `animated` - properties added to `AcsMessageReceivedEventData` - `messageId` - `messageType` - `reaction` ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? This is straight code regeneration and minor fix to adopt code-gen changes. ### Are there test cases added in this PR? _(If not, why?)_ No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient. ### Provide a list of related PRs _(if any)_ #32441 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ `npm run generate:client` ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/eventgridIssues associated with this PR
Azure/azure-rest-api-specs#32004
Describe the problem that is addressed by this PR
This PR consists of the following changes:
internetMessageIdproperty toAcsEmailDeliveryReportReceivedEventData.recipientMailServerHostNameproperty toAcsEmailDeliveryReportStatusDetails.AcsSmsReceivedEventData:segmentCountpropertymessage&receivedTimestampproperties optional.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
There are no specific/complex design scenarios for this task. It is a straightforward regenerate and some standard changes to the custom layer of the code.
Are there test cases added in this PR? (If not, why?)
No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
autorest --typescript swagger\README.mdChecklists