-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR] @azure/arm-network #4496
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed incorrect API version in NetworkWatcher's examples
openapi-sdkautomation
bot
requested review from
michaeljqzq and
ramya-rao-a
as code owners
July 29, 2019 17:15
This was referenced Jul 29, 2019
- Bundle core-http instead of requiring as external
- Dependency was accidentally added with a `~` instead of `^`
…ition (#4467) * [EPH] Call methods on PartitionProcessor while processing single partition
Fixed incorrect API version in NetworkWatcher's examples
…/Azure/azure-sdk-for-js into sdkAutomation/@azure/arm-network
openapi-sdkautomation
bot
requested review from
chradek,
daviwil,
HarshaNalluru,
jeremymeng,
sophiajt,
sadasant,
ShivangiReja,
vinjiang and
XiaoningLiu
as code owners
July 30, 2019 09:17
ramya-rao-a
removed request for
sophiajt,
sadasant,
ShivangiReja,
vinjiang and
XiaoningLiu
July 30, 2019 15:28
ramya-rao-a
suggested changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider creating this PR from a clean branch
It has changes not relevant to arm-network
Fixed incorrect API version in NetworkWatcher's examples
…/Azure/azure-sdk-for-js into sdkAutomation/@azure/arm-network
fix: network model validation errors - Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors - Remove responses for 202s with no schema defined for RESPONSE_SCHEMA_NOT_IN_SPEC errrors - The OBJECT_ADDITIONAL_PROPERTIES are not addressed - "Thumbprint" -> "thumbprint"
Add missing bodies in AppGw's examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to accumulate changes for: @azure/arm-network