[Graph] Fix code samples in README

[mikesprague]

Code samples for the Graph client do not work as written. This PR updates the samples with the necessary changes for them to run.

• Uses tenantId vs subscriptionId in Node and browser code examples
• Removes extraneous curly brackets from Node example
• Adds domain to interactiveLogin call in Node example

[ramya-rao-a]

How is this tenantId different from the one in line 33?

[mikesprague]

Hi @ramya-rao-a - they are part of separate code examples. The tenantId on line 74 is part of the browser-specific example, whereas the one on line 33 you mentioned is part of the Node.js example. In practice, they should never be used together so there wouldn't actually be redundant variables.

[ramya-rao-a]

Oh, thats right. Apologies, that was an oversight from my end :)

[ramya-rao-a]

In that case, I would suggest to update line 33 to const tenantId = "<Tenant_Id>"; as well because we dont talk about the environment variable DOMAIN needing to be set anywhere in the readme.

[mikesprague]

Sure, that makes sense. I was trying to change the original code as little as possible and it referenced an env var for subscription id prior to my other updates.

There's some additional code that can be removed (the following imports on lines 29-30 aren't used and aren't necessary for the example to run, I have tested this):

import * as msRest from "@azure/ms-rest-js";
import * as msRestAzure from "@azure/ms-rest-azure-js";

I have added a couple commits with the above changes.

[ramya-rao-a]

Thanks for getting started on this @mikesprague!
Hopefully, we should be able to close #4292 with this.

[ramya-rao-a]

This looks good.
Before I merge, can you share some pointers to the docs that talk about tenant id for Azure Graph?

[mikesprague]

The source code for the current SDK (azure-sdk-for-js) references the tenantID in the constructor for the GraphRbacManagementClient:

• azure-sdk-for-js/sdk/graphrbac/graph/src/graphRbacManagementClient.ts

  Line 36 in 56bd4aa

  constructor(credentials: msRest.ServiceClientCredentials, tenantID: string, options?: Models.GraphRbacManagementClientOptions) {

Also, here are the examples from the "old" SDK (azure-sdk-for-node) that also point to tenantId vs subscriptionId:

• https://azure.github.io/azure-sdk-for-node/azure-graph/latest/

FWIW, I spent more time then I'd like to admit trying to get the examples (as currently listed on the README) to work using the subscription id. While that wasn't the only issue, I have gone back and compared using subscription id to tenant id and subscription id fails/errors out every time.

[ramya-rao-a]

Thanks for all the time you have spent on this @mikesprague!

This library has been auto-generated and so have the samples in the README file.
We are looking at improving this process, but this has been a great first step towards that.

Thanks again!