[Storage] Drop RawTokenCredential from storage packages
#4788
Conversation
HarshaNalluru
added
Client
HarshaNalluru
requested review from
jeremymeng,
jiacfan and
vinjiang
as code owners
| @@ -167,13 +167,6 @@ async function main() { | |||
| // SharedKeyCredential is only avaiable in Node.js runtime, not in browsers | |||
| const sharedKeyCredential = new SharedKeyCredential(account, accountKey); | |||
|
|
|||
| // Use RawTokenCredential with OAuth token. You can find more | |||
There was a problem hiding this comment.
We should leave a sample here for customers who want OAuth authentication.
There was a problem hiding this comment.
Maybe linking to the @azure/identity npmjs page. There's some documentation there.
sdk/storage/README.md
Outdated
| @@ -167,11 +167,11 @@ async function main() { | |||
| // SharedKeyCredential is only avaiable in Node.js runtime, not in browsers | |||
| const sharedKeyCredential = new SharedKeyCredential(account, accountKey); | |||
|
|
|||
| // Use RawTokenCredential with OAuth token. You can find more | |||
| // Use SimpleTokenCredential with OAuth token. You can find more | |||
| // TokenCredential implementations in the @azure/identity library | |||
There was a problem hiding this comment.
About description "from @azure/identity".
SimpleTokenCredential is from @azure/core-http while other TokenCredential implmenetations from @azure/identity. We'd better make the description clearer.
There was a problem hiding this comment.
This should be taking TokenCredential not SimpleTokenCredential
There was a problem hiding this comment.
I opened issue #4968 to remove SimpleTokenCredential from core-auth
There was a problem hiding this comment.
Okay. SimpleTokenCredential should be removed from core-auth and won't be exposed in our libraries.
@XiaoningLiu, you've recently added some tests that leverage SimpleTokenCredential a few days ago.
Should we implement this SimpleTokenCredential class on top of TokenCredential in the test/utils/index.ts to leverage it just for the tests and not expose it anywhere else from the library?
There was a problem hiding this comment.
@HarshaNalluru Sounds good. One question about removing SimpleTokenCredential. This is the raw or last way for customers to create a TokenCredential. Does @azure/identity work with Node.js & browsers to get a TokenCredential?
There was a problem hiding this comment.
@azure/identity provides many types of TokenCredentials for both Node.js & browsers.
Created and issue to test and to add samples - #5051
|
I was not aware that we advocated users to use the older |
HarshaNalluru
changed the title
RawTokenCredential in favour of SimpleTokenCredentialRawTokenCredential from storage packages
Issue - #4636
@azure/core-http now provides a SimpleTokenCredential, RawTokenCredential can be dropped from storage-packages(blob and queue).
Update -
Removing RawTokenCredential completely.