Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] BlobSASSignatureValues could use BlobSASPermissions type for permissions instead of string #5626

Merged
merged 4 commits into from
Oct 18, 2019
Merged

[Storage] BlobSASSignatureValues could use BlobSASPermissions type for permissions instead of string #5626

merged 4 commits into from
Oct 18, 2019

Conversation

HarshaNalluru
Copy link
Member

No description provided.

@HarshaNalluru HarshaNalluru requested review from biblix and bterlson and removed request for biblix October 17, 2019 17:48
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 17, 2019
@jiacfan
Copy link
Member

jiacfan commented Oct 18, 2019

Would we provide example/sample for BlobSASSignatureValues? I think that would be helpful.

jiacfan
jiacfan approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@jiacfan jiacfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@HarshaNalluru
Copy link
Member Author

"rush rebuild" succeeded locally.
Unit tests for all the storage packages are also fine.
Not waiting for the CI checks. Merging this.

@HarshaNalluru HarshaNalluru merged commit efbcb75 into Azure:master Oct 18, 2019
This was referenced Oct 18, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacfan jiacfan jiacfan approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@vinjiang vinjiang Awaiting requested review from vinjiang

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

@bterlson bterlson Awaiting requested review from bterlson

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshaNalluru @jiacfan @jeremymeng