[Storage] Fixing code coverage for the browser tests #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
bterlson,
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
…to FixCodeCoverageBrowser
HarshaNalluru
changed the title
HarshaNalluru
added
Client
|
It would be nice to add into the description summary of the issue and fix |
I was just adding some :P |
It would've been filled if you have some words in the first commit! |
|
If the approach and the report look good, I'll extend this to the rest of the SDKs. |
bterlson
approved these changes
Dec 20, 2019
jeremymeng
approved these changes
Dec 21, 2019
ramya-rao-a
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Coverage for Browser Tests
Problem
Code coverage for browser tests is broken.
Investigation
karma plugins
karma-coverageis supposed to generate a report showing the code covered while testing(for the file
dist-test/index.browser.js). This works properly.karma-remap-coverageis supposed to remap the above coverage and show the code covered in the src files using the sourceMappings. This is broken, the report shown is blank.Looks like the package(karma-remap-coverage) has not been responding to the issues in github and is deprecated too - karma-remap-coverage
After failed many attempts at fixing it, finally gave up and started looking for alternatives to karma-remap-coverage.. came across karma-remap-istanbul
Tried that instead of karma-remap-coverage(updated karma.conf appropriately), I could generate a report like following.
Fixes #2937