Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyvault] Include coverage in integration-test script #6719

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

ramya-rao-a
Copy link
Contributor

Follow up for Keyvault from #6713

In #6430, we removed the call to nyc from the integration scripts and introduced a new npm script for generating code coverage. This results in 2 main issues

  • Nightly test runs no longer run nyc
  • We will need to set up a new step to run the new npm script that will result in running the same set of tests twice

This PR attempts to remove the need for the new npm script by removing the dependency on integration scripts among the other scripts.

Other changes are to ensure that the test script is the same as unit-test in packages that support record/playback.

@ramya-rao-a ramya-rao-a changed the title [Keyvaul] Include coverage in integration-test script [Keyvault] Include coverage in integration-test script Dec 31, 2019
@ramya-rao-a ramya-rao-a merged commit 4c56c5b into Azure:master Jan 2, 2020
@ramya-rao-a ramya-rao-a deleted the npm-scripts branch January 2, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants