[Service Bus] Pass abortsignal to retry() #8202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
chradek,
HarshaNalluru and
richardpark-msft
as code owners
| @@ -323,7 +323,7 @@ export class ReceiverImpl<ReceivedMessageT extends ReceivedMessage | ReceivedMes | |||
| connectionId: this._context.namespace.connectionId, | |||
| operation: receiveMessages, | |||
| operationType: RetryOperationType.receiveMessage, | |||
| abortSignal: undefined, | |||
| abortSignal: options?.abortSignal, | |||
There was a problem hiding this comment.
I think the only things that are left out in this PR are streaming receiver and the send operations.
There was a problem hiding this comment.
send operations & streaming receiver do not respect abort signal at the moment, @richardpark-msft is working on it
|
Related to #4375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry() method takes an abort signal and uses it abort the waiting done in between retries.
This PR ensures that the abortSignal gets passed in to this method.