Workaround @types/qs breakage #8832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
fyi @sadasant as this may be related to the discussion in #8782 (comment) |
Contributor
The more specific return types were added to a version of |
ramya-rao-a
reviewed
May 11, 2020
sdk/identity/identity/test/node/clientCertificateCredential.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ramya-rao-a - exactly. This will help unblock us so we can be ready for the upgrade |
ramya-rao-a
approved these changes
May 11, 2020
KarishmaGhiya
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the @types/qs breakage, where return types were recently made more specific. This caused issues where we assume it's returning 'any'.
With this, it's possible to do a
rush update --fullcc @KarishmaGhiya