Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormRecognizer] Bring back Azure AD credential support #8898

Merged
merged 2 commits into from
May 15, 2020
Merged

[FormRecognizer] Bring back Azure AD credential support #8898

merged 2 commits into from
May 15, 2020

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. FormRecognizer labels May 13, 2020
willmtemple
willmtemple approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@willmtemple willmtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have tests to verify that AAD auth is working?

@jeremymeng
Copy link
Member Author

LGTM. Do we have tests to verify that AAD auth is working?

Not yet. Logged #8943

@jeremymeng jeremymeng merged commit cebbff5 into Azure:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmtemple willmtemple willmtemple approved these changes

@bterlson bterlson Awaiting requested review from bterlson

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremymeng @willmtemple