Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] Change imports from dist-esm to src in tests #8936

Merged
merged 8 commits into from
May 20, 2020

Conversation

zfoster
Copy link
Contributor

@zfoster zfoster commented May 14, 2020

Now that we're running tests with ts-node on the fly, we don't need to import from dist-esm, which was the original cause of the testing issues where builds would become incompatible during development with the current built js.

Also skips the SDK_VERSION test locally as it requires a full build

@jeremymeng
Copy link
Member

build:test might be needed in the build pipeline by convention. /cc @KarishmaGhiya @danieljurek

@danieljurek
Copy link
Member

/azp run js - cosmos - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@zfoster
Copy link
Contributor Author

zfoster commented May 15, 2020 via email

@danieljurek
Copy link
Member

danieljurek commented May 15, 2020

Ah yes, Cosmos does emulator tests. These tests are failing because the integration pipeline uses build:test ... Add it back in and the pipeline should make it past that step.

@zfoster zfoster merged commit c0c8bce into Azure:master May 20, 2020
@zfoster zfoster deleted the zf/test-imports branch May 20, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants