[Service Bus] Adding the missing pieces for the ATOM API #9221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to harshan/sb/issue/atom-api
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to harshan/sb/issue/atom-with-new-APIs
HarshaNalluru
requested review from
bterlson,
chradek,
qiaozha and
richardpark-msft
as code owners
ramya-rao-a
reviewed
Jun 4, 2020
| } catch (error) { | ||
| if (error.code == "MessageEntityNotFoundError") { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Shouldnt this throw the error if the error was not MessageEntityNotFoundError? Same for other "exists" method
cc @ShivangiReja
There was a problem hiding this comment.
That's probably better.
I think .NET SDK should also update accordingly.
There was a problem hiding this comment.
Updated in this PR.
|
/azp run js - servicebus - tests |
ramya-rao-a
reviewed
Jun 4, 2020
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Jun 4, 2020
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Jun 4, 2020
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Jun 4, 2020
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Jun 4, 2020
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #9116
Changes in the PR
(Implementation and testing ongoing)
Constructor overload to create ManagementClient to take the token credential(Separate PR since it requires more work -[Service Bus] Token Credential Overload for ATOM Mgmt Client #9316)