Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Token Credential Overload for ATOM Mgmt Client #9316

Merged
merged 68 commits into from
Jun 6, 2020
Merged

[Service Bus] Token Credential Overload for ATOM Mgmt Client #9316

Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
8b7a544
Update Queue APIs aper the .NET proposal
HarshaNalluru May 26, 2020
ff97456
remove @internal @ignore tags wherever required and generate API report
HarshaNalluru May 26, 2020
ac287ab
more exports
HarshaNalluru May 26, 2020
4c24583
more and more exports
HarshaNalluru May 26, 2020
681430f
Add token credential constructor overlaod
HarshaNalluru May 27, 2020
6d0ef77
doesExist() for queue, topic and subscription
HarshaNalluru May 27, 2020
402e988
generate API report
HarshaNalluru May 27, 2020
0f0dad4
api extractor and ts-config (TO BE REVERTED)
HarshaNalluru May 27, 2020
31bf847
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Jun 1, 2020
ce8e83e
feedback from the service team
HarshaNalluru Jun 1, 2020
0d66b37
update index.ts
HarshaNalluru Jun 1, 2020
3eaaf9b
update API report
HarshaNalluru Jun 1, 2020
f77d450
Update queue related imports in tests
HarshaNalluru Jun 1, 2020
7244666
revert api-extractor and tsconfig changes to allow compiling tests
HarshaNalluru Jun 1, 2020
54e738f
fix build failures of ATOM API tests
HarshaNalluru Jun 1, 2020
572917a
changes to rule options and interfaces
HarshaNalluru Jun 1, 2020
988eb84
fix test failures
HarshaNalluru Jun 1, 2020
b1766b2
changes to Topic APIs
HarshaNalluru Jun 1, 2020
07f0a2d
fix build failures
HarshaNalluru Jun 1, 2020
b4546b3
generate API report
HarshaNalluru Jun 1, 2020
09a1c04
subscription APIs updated
HarshaNalluru Jun 1, 2020
5a58aca
fix build failures
HarshaNalluru Jun 1, 2020
92ba1a4
generate API report
HarshaNalluru Jun 1, 2020
5cb629a
fix API report warnings
HarshaNalluru Jun 1, 2020
ab59d31
changes to rule APIs
HarshaNalluru Jun 1, 2020
7514824
fix build failures
HarshaNalluru Jun 1, 2020
a5e164b
generate API report
HarshaNalluru Jun 1, 2020
e944464
getNamespaceProperties API
HarshaNalluru Jun 2, 2020
fece100
namespace info improvement + API report
HarshaNalluru Jun 2, 2020
ea5f1d5
fix warnings in the API report
HarshaNalluru Jun 2, 2020
adca0d2
generatre API report
HarshaNalluru Jun 2, 2020
e0d2e77
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Jun 3, 2020
c2a6092
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Jun 3, 2020
243187d
resolve merge conflicts and organize imports
HarshaNalluru Jun 3, 2020
1a41ea1
fix the warnings from API report
HarshaNalluru Jun 3, 2020
7aa01a2
API report
HarshaNalluru Jun 3, 2020
e2ead3b
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Jun 3, 2020
a67bee1
tests for getRuntimeInfo API for a single entity
HarshaNalluru Jun 3, 2020
887b94f
remove messageCount from *Description APIs
HarshaNalluru Jun 3, 2020
0870157
remove unused helper
HarshaNalluru Jun 4, 2020
e44d909
test for Get namespace properties
HarshaNalluru Jun 4, 2020
f8a0de7
tests for entityExists
HarshaNalluru Jun 4, 2020
ee59bda
tests for getEntitiesRuntimeInfo
HarshaNalluru Jun 4, 2020
50c22a5
Add changelog
HarshaNalluru Jun 4, 2020
e23aa2b
Changelog
HarshaNalluru Jun 4, 2020
d11567d
tokenProvider attempt to fix
HarshaNalluru Jun 4, 2020
5ff994e
added servicebus scope in the getToken attribute
HarshaNalluru Jun 4, 2020
99083eb
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Jun 4, 2020
4ce81ef
mark "@azure/identity" as external
HarshaNalluru Jun 4, 2020
bd19e38
Token credential
HarshaNalluru Jun 5, 2020
988d927
test for Token credential - DefaultAzureCredential from `@azure/ident…
HarshaNalluru Jun 5, 2020
8fa3fb0
update the name
HarshaNalluru Jun 5, 2020
9ac0e4e
Update sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
HarshaNalluru Jun 5, 2020
a772c7f
Update sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
HarshaNalluru Jun 5, 2020
faad510
enter one more code path in the tests for gettoken invocation
HarshaNalluru Jun 5, 2020
8aa7907
Merge branch 'harshan/sb/issue/atom-token-cred' of https://github.com…
HarshaNalluru Jun 5, 2020
99488c9
refactoring the constructor as suggested by Chris and fixing tests
HarshaNalluru Jun 5, 2020
5b0e41b
fix trailing slash issue
HarshaNalluru Jun 5, 2020
298df4a
Update the test to cover more cases
HarshaNalluru Jun 5, 2020
52477cd
fix test for AAD
HarshaNalluru Jun 5, 2020
a6a4b50
remove unneeded !
HarshaNalluru Jun 5, 2020
8c3b5b4
fix endpoint and endpointWithProtocol attributes
HarshaNalluru Jun 5, 2020
c037a86
Add getToken for SasServiceCredential
HarshaNalluru Jun 5, 2020
082afc4
merge tokenProvider into credentials
HarshaNalluru Jun 5, 2020
781c41d
remove "@azure/ms-rest-nodeauth" from the external list in roll…
HarshaNalluru Jun 5, 2020
1df7bd2
Update sdk/servicebus/service-bus/rollup.base.config.js
HarshaNalluru Jun 5, 2020
518e696
private sharedKeyCredential
HarshaNalluru Jun 5, 2020
bcab28f
Merge branch 'harshan/sb/issue/atom-token-cred' of https://github.com…
HarshaNalluru Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions sdk/servicebus/service-bus/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,7 @@ export function nodeConfig({ test = false, production = false } = {}) {
baseConfig.output.file = "test-dist/index.js";

// mark assert as external
baseConfig.external.push(
"assert",
"fs",
"path",
"@azure/arm-servicebus",
"@azure/ms-rest-nodeauth",
"@azure/identity"
);
baseConfig.external.push("assert", "fs", "path", "@azure/arm-servicebus", "@azure/identity");
HarshaNalluru marked this conversation as resolved.
Show resolved Hide resolved

baseConfig.onwarn = ignoreKnownWarnings;

Expand Down