Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regeneration and Other changes #9711

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Regeneration and Other changes #9711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f93216b
Regeneration and Other changes
sarangan12 Jun 25, 2020
d14e355
Test Build Fix
sarangan12 Jun 25, 2020
021cc68
Merge remote-tracking branch 'origin/master' into RegenerateSearchSDK…
sarangan12 Jun 25, 2020
0af7b4c
Minor Regenerate Change
sarangan12 Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .scripts/readme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export async function getSinglePackageName(typescriptReadmePath: string): Promis
const readmeBuffer: Buffer = await fs.readFile(typescriptReadmePath);
const yamlSectionBuffer = await getYamlSection(readmeBuffer, "``` yaml $(typescript)", "```");
const yamlSectionText = yamlSectionBuffer.toString();
const yamlSection = yaml.safeLoad(yamlSectionText);
const yamlSection:any = yaml.safeLoad(yamlSectionText);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this have to change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing a build error with the npm run build step. The only way that got fixed was to have this. Since this was a harmless code, I let it slide :-)

return yamlSection["typescript"]["package-name"];
}

Expand Down
7 changes: 6 additions & 1 deletion sdk/search/search-documents/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Release History

## 1.0.0-preview.5 (Unreleased)
## 11.0.0 (2020-07-06)
- Set `ConnectionString` value to `<unchanged>` in `SearchIndexerDataSourceConnection`, if the value is not set by the user.
- [Breaking] In Suggest API & Search API return values, a new property called `document` is introduced. All user-defined fields are moved inside this `document` property.
- [Breaking] In `analyzeText` API, the `text` parameter is moved from method level to inside `options` bag.
- [Breaking] In `search` API, `includeTotalResultCount` property is renamed to `includeTotalCount`.
- [Breaking] Modified the names of several properties. Please refer [#9321](https://github.com/Azure/azure-sdk-for-js/issues/9321) for a detailed list of renames.


## 1.0.0-preview.4 (2020-06-08)
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ async function main() {
main();
```

For a more advanced search that uses [Lucene syntax](https://docs.microsoft.com/azure/search/query-lucene-syntax), specify `queryType` to be `all`:
For a more advanced search that uses [Lucene syntax](https://docs.microsoft.com/azure/search/query-lucene-syntax), specify `queryType` to be `full`:

```js
const { SearchClient, AzureKeyCredential } = require("@azure/search-documents");
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@azure/search-documents",
"version": "1.0.0-preview.5",
"version": "11.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a preview.5 still? I am not sure if the release pipeline in JS will take care of removing the suffix or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexGhiondea It we have preview then it will be released as 11.0.0-preview. I do not think we need that. We want to release this as 11.0.0 and mention the same. The release pipeline does not do any changes.

"description": "Azure client library to use Cognitive Search for node.js and browser.",
"sdk-type": "client",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

export const SDK_VERSION: string = "1.0.0-preview.5";
export const SDK_VERSION: string = "11.0.0";
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/generated/data/searchClientContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import * as coreHttp from "@azure/core-http";

const packageName = "@azure/search-documents";
const packageVersion = "1.0.0-preview.5";
const packageVersion = "11.0.0";

export class SearchClientContext extends coreHttp.ServiceClient {
apiVersion: string;
Expand Down
12 changes: 6 additions & 6 deletions sdk/search/search-documents/src/generated/service/models/parameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,21 @@ export const ifNoneMatch: coreHttp.OperationParameter = {
}
}
};
export const indexName: coreHttp.OperationURLParameter = {
parameterPath: "indexName",
export const indexerName: coreHttp.OperationURLParameter = {
parameterPath: "indexerName",
mapper: {
required: true,
serializedName: "indexName",
serializedName: "indexerName",
type: {
name: "String"
}
}
};
export const indexerName: coreHttp.OperationURLParameter = {
parameterPath: "indexerName",
export const indexName: coreHttp.OperationURLParameter = {
parameterPath: "indexName",
mapper: {
required: true,
serializedName: "indexerName",
serializedName: "indexName",
type: {
name: "String"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/generated/service/searchServiceClientContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import * as coreHttp from "@azure/core-http";

const packageName = "@azure/search-documents";
const packageVersion = "1.0.0-preview.5";
const packageVersion = "11.0.0";

export class SearchServiceClientContext extends coreHttp.ServiceClient {
apiVersion: string;
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/searchClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class SearchClient<T> {
/**
* The API version to use when communicating with the service.
*/
public readonly apiVersion: string = "2019-05-06-Preview";
public readonly apiVersion: string = "2020-06-30";

/**
* The endpoint of the search service
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/searchIndexClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class SearchIndexClient {
/**
* The API version to use when communicating with the service.
*/
public readonly apiVersion: string = "2019-05-06-Preview";
public readonly apiVersion: string = "2020-06-30";

/**
* The endpoint of the search service
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/src/searchIndexerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class SearchIndexerClient {
/**
* The API version to use when communicating with the service.
*/
public readonly apiVersion: string = "2019-05-06-Preview";
public readonly apiVersion: string = "2020-06-30";

/**
* The endpoint of the search service
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/swagger/Data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ generate-metadata: false
license-header: MICROSOFT_MIT_NO_VERSION
output-folder: ../
source-code-folder-path: ./src/generated/data
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchindex.json
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/search/data-plane/Azure.Search/preview/2020-06-30/searchindex.json
add-credentials: false
title: SearchClient
use-extension:
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/swagger/Service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ generate-metadata: false
license-header: MICROSOFT_MIT_NO_VERSION
output-folder: ../
source-code-folder-path: ./src/generated/service
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/search/data-plane/Azure.Search/preview/2020-06-30/searchservice.json
add-credentials: false
use-extension:
"@microsoft.azure/autorest.typescript": "5.0.1"
Expand Down