Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing dev feed for private package on script level and with artifact parameter option in pipeline #9948

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Preventing dev feed for private package on script level and with artifact parameter option in pipeline #9948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fdb5cb
getting that private package out of dev feed
KarishmaGhiya Jul 8, 2020
296c7d2
unsure about this pipeline change
KarishmaGhiya Jul 8, 2020
16dc86c
test template
KarishmaGhiya Jul 8, 2020
b944ca9
test template
KarishmaGhiya Jul 8, 2020
fea4cbf
remove the options from template
KarishmaGhiya Jul 8, 2020
9d7a099
add config to tables
KarishmaGhiya Jul 9, 2020
d4c231e
indentation
KarishmaGhiya Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pipelines/templates/stages/archetype-js-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ stages:
artifact: ${{parameters.ArtifactName}}
timeoutInMinutes: 5
- ${{ each artifact in parameters.Artifacts }}:
- ${{if ne(artifact.options.skipPublishDevFeed, 'true')}}:
KarishmaGhiya marked this conversation as resolved.
Show resolved Hide resolved
- pwsh: |
$detectedPackageName=Get-ChildItem $(Pipeline.Workspace)/${{parameters.ArtifactName}}/${{artifact.name}}-*-dev*.tgz
echo "##vso[task.setvariable variable=Package.Archive]$detectedPackageName"
Expand Down
3 changes: 2 additions & 1 deletion eng/tools/versioning/set-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ async function main(argv) {
for (const package of Object.keys(rushPackages)) {
if (
["client", "core"].includes(rushPackages[package].versionPolicy) &&
rushPackages[package].projectFolder.startsWith(`sdk/${service}`)
rushPackages[package].projectFolder.startsWith(`sdk/${service}`) &&
!rushPackages[package].json["private"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really help with anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. it won't change attach the dev versioning for private packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will work for all private packages even if they forget to set the skippublishdevfeed variable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But all it does is prevent the dev version from being set on the package it doesn't do anything about not publishing it. While I don't mind this change I'm not sure it really adds much for us.

) {
targetPackages.push(package);
}
Expand Down
2 changes: 2 additions & 0 deletions sdk/tables/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ extends:
Artifacts:
- name: azure-tables
safeName: azuretables
options:
skipPublishDevFeed: true