Azure.Provisioning: API cleanup (#46735)

- Removing features that won't be shipping as GA (like preview versions, `IClientCreator`, `StorageResources`, etc.) and hiding them behind a feature flag - Fixes #46559 to correctly serialize ISO8601 duration `TimeSpan`s by adding a `Format` to `BicepValue`. - Fixes #46558 to change string interpolation to use `InterpolatedStringHandler` and also add a `BicepStringBuilder`
Azure · Oct 21, 2024 · 3fadc42 · 3fadc42
1 parent 8f98f23
commit 3fadc42
Show file tree

Hide file tree

Showing 284 changed files with 640 additions and 1,530 deletions.
diff --git a/...g/Azure.Provisioning.AppContainers/api/Azure.Provisioning.AppContainers.netstandard2.0.cs b/...g/Azure.Provisioning.AppContainers/api/Azure.Provisioning.AppContainers.netstandard2.0.cs
@@ -60,7 +60,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public enum ContainerAppAccessMode
@@ -112,7 +111,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppAuthPlatform : Azure.Provisioning.Primitives.ProvisionableConstruct
@@ -228,7 +226,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppConnectedEnvironmentCertificate : Azure.Provisioning.Primitives.ProvisionableResource
@@ -247,7 +244,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppConnectedEnvironmentDaprComponent : Azure.Provisioning.Primitives.ProvisionableResource
@@ -271,7 +267,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public enum ContainerAppConnectedEnvironmentProvisioningState
@@ -299,7 +294,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppContainer : Azure.Provisioning.Primitives.ProvisionableConstruct
@@ -632,7 +626,6 @@ public static partial class ResourceVersions
         {
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppJobConfiguration : Azure.Provisioning.Primitives.ProvisionableConstruct
@@ -733,7 +726,6 @@ public static partial class ResourceVersions
         {
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppManagedEnvironment : Azure.Provisioning.Primitives.ProvisionableResource
@@ -771,7 +763,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppManagedEnvironmentCertificate : Azure.Provisioning.Primitives.ProvisionableResource
@@ -791,7 +782,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppManagedEnvironmentDaprComponent : Azure.Provisioning.Primitives.ProvisionableResource
@@ -816,7 +806,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public enum ContainerAppManagedEnvironmentOutBoundType
@@ -839,7 +828,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public partial class ContainerAppOpenIdConnectClientCredential : Azure.Provisioning.Primitives.ProvisionableConstruct
@@ -990,7 +978,6 @@ public static partial class ResourceVersions
             public static readonly string V2022_10_01;
             public static readonly string V2023_05_01;
             public static readonly string V2024_03_01;
-            public static readonly string V2024_08_02_preview;
         }
     }
     public enum ContainerAppSourceControlOperationState

diff --git a/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerApp.cs b/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerApp.cs
diff --git a/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppAuthConfig.cs b/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppAuthConfig.cs
diff --git a/...ioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironment.cs b/...ioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironment.cs
diff --git a/...e.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentCertificate.cs b/...e.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentCertificate.cs
diff --git a/...Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentDaprComponent.cs b/...Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentDaprComponent.cs
diff --git a/...Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentStorage.cs b/...Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentStorage.cs
diff --git a/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppJob.cs b/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppJob.cs
diff --git a/...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedCertificate.cs b/...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedCertificate.cs
diff --git a/...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironment.cs b/...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironment.cs
diff --git a/...ure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentCertificate.cs b/...ure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentCertificate.cs
diff --git a/...e.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentDaprComponent.cs b/...e.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentDaprComponent.cs
diff --git a/...g/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentStorage.cs b/...g/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentStorage.cs
diff --git a/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppSourceControl.cs b/sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppSourceControl.cs
diff --git a/...isioning.ApplicationInsights/api/Azure.Provisioning.ApplicationInsights.netstandard2.0.cs b/...isioning.ApplicationInsights/api/Azure.Provisioning.ApplicationInsights.netstandard2.0.cs
@@ -78,7 +78,6 @@ public static partial class ResourceVersions
             public static readonly string V2014_08_01;
             public static readonly string V2015_05_01;
             public static readonly string V2020_02_02;
-            public static readonly string V2020_02_02_preview;
         }
     }
     public enum ApplicationInsightsPublicNetworkAccessType

diff --git a/...ning/Azure.Provisioning.ApplicationInsights/src/Generated/ApplicationInsightsComponent.cs b/...ning/Azure.Provisioning.ApplicationInsights/src/Generated/ApplicationInsightsComponent.cs
diff --git a/sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/Azd.cs b/sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/Azd.cs
@@ -37,7 +37,7 @@ internal static void Init(string infraDirectory, CloudMachineInfrastructure cmi)
 
         Infrastructure mainBicep = new("main")
         {
-            TargetScope = "subscription"
+            TargetScope = DeploymentScope.Subscription
         };
         ModuleImport import = new("cm", $"cm.bicep")
         {

diff --git a/sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/CloudMachineInfrastructure.cs b/sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/CloudMachineInfrastructure.cs
@@ -77,7 +77,14 @@ public CloudMachineInfrastructure(string cmId)
             UserAssignedIdentities = { { BicepFunction.Interpolate($"{Identity.Id}").Compile().ToString(), new UserAssignedIdentityDetails() } }
         };
 
-        _storage = StorageResources.CreateAccount("cm_storage");
+        _storage =
+            new StorageAccount("cm_storage", StorageAccount.ResourceVersions.V2023_01_01)
+            {
+                Kind = StorageKind.StorageV2,
+                Sku = new StorageSku { Name = StorageSkuName.StandardLrs },
+                IsHnsEnabled = true,
+                AllowBlobPublicAccess = false
+            };
         _storage.Identity = managedServiceIdentity;
         _storage.Name = _cmid;
 
@@ -110,7 +117,7 @@ public CloudMachineInfrastructure(string cmId)
             Name = "cm_servicebus_topic_private",
             Parent = _serviceBusNamespace,
             MaxMessageSizeInKilobytes = 256,
-            DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
+            DefaultMessageTimeToLive = TimeSpan.FromDays(14),
             RequiresDuplicateDetection = false,
             EnableBatchedOperations = true,
             SupportOrdering = true,
@@ -121,9 +128,9 @@ public CloudMachineInfrastructure(string cmId)
             Name = SB_PRIVATE_SUB,
             Parent = _serviceBusTopic_private,
             IsClientAffine = false,
-            LockDuration = new StringLiteralExpression("PT30S"),
+            LockDuration = TimeSpan.FromSeconds(30),
             RequiresSession = false,
-            DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
+            DefaultMessageTimeToLive = TimeSpan.FromDays(14),
             DeadLetteringOnFilterEvaluationExceptions = true,
             DeadLetteringOnMessageExpiration = true,
             MaxDeliveryCount = 10,
@@ -135,7 +142,7 @@ public CloudMachineInfrastructure(string cmId)
             Name = "cm_servicebus_default_topic",
             Parent = _serviceBusNamespace,
             MaxMessageSizeInKilobytes = 256,
-            DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
+            DefaultMessageTimeToLive = TimeSpan.FromDays(14),
             RequiresDuplicateDetection = false,
             EnableBatchedOperations = true,
             SupportOrdering = true,
@@ -146,9 +153,9 @@ public CloudMachineInfrastructure(string cmId)
             Name = "cm_servicebus_subscription_default",
             Parent = _serviceBusTopic_default,
             IsClientAffine = false,
-            LockDuration = new StringLiteralExpression("PT30S"),
+            LockDuration = TimeSpan.FromSeconds(30),
             RequiresSession = false,
-            DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
+            DefaultMessageTimeToLive = TimeSpan.FromDays(14),
             DeadLetteringOnFilterEvaluationExceptions = true,
             DeadLetteringOnMessageExpiration = true,
             MaxDeliveryCount = 10,

diff --git a/...g/Azure.Provisioning.Communication/api/Azure.Provisioning.Communication.netstandard2.0.cs b/...g/Azure.Provisioning.Communication/api/Azure.Provisioning.Communication.netstandard2.0.cs
@@ -22,7 +22,6 @@ public static partial class ResourceVersions
         {
             public static readonly string V2023_03_31;
             public static readonly string V2023_04_01;
-            public static readonly string V2023_06_01_preview;
         }
     }
     public partial class CommunicationService : Azure.Provisioning.Primitives.ProvisionableResource
@@ -50,7 +49,6 @@ public static partial class ResourceVersions
             public static readonly string V2020_08_20;
             public static readonly string V2023_03_31;
             public static readonly string V2023_04_01;
-            public static readonly string V2023_06_01_preview;
         }
     }
     public partial class CommunicationServiceKeys : Azure.Provisioning.Primitives.ProvisionableConstruct
@@ -153,7 +151,6 @@ public static partial class ResourceVersions
         {
             public static readonly string V2023_03_31;
             public static readonly string V2023_04_01;
-            public static readonly string V2023_06_01_preview;
         }
     }
     public enum EmailServicesProvisioningState
@@ -184,7 +181,6 @@ public static partial class ResourceVersions
         {
             public static readonly string V2023_03_31;
             public static readonly string V2023_04_01;
-            public static readonly string V2023_06_01_preview;
         }
     }
     public enum UserEngagementTracking

diff --git a/sdk/provisioning/Azure.Provisioning.Communication/src/Generated/CommunicationDomain.cs b/sdk/provisioning/Azure.Provisioning.Communication/src/Generated/CommunicationDomain.cs