[MetricsAdvisor] Renamed SkipCount to Skip (#20990)

Azure · May 11, 2021 · 70fe7ec · 70fe7ec
1 parent 939e15a
commit 70fe7ec
Show file tree

Hide file tree

Showing 16 changed files with 51 additions and 50 deletions.
diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/CHANGELOG.md b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.0.0-beta.4 (Unreleased)
 
 ### Breaking Changes
+- Renamed all `SkipCount` listing options to `Skip`. Affected classes include `GetAlertsOptions`, `GetDataFeedsOptions`, `GetHooksOptions`, and others.
 - Renamed all `TopCount` listing options to `MaxPageSize`. Affected classes include `GetAlertsOptions`, `GetDataFeedsOptions`, `GetHooksOptions`, and others.
 
 ## 1.0.0-beta.3 (2021-02-09)

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs
@@ -42,7 +42,7 @@ public partial class GetAlertsOptions
         public GetAlertsOptions(System.DateTimeOffset startTime, System.DateTimeOffset endTime, Azure.AI.MetricsAdvisor.AlertQueryTimeMode timeMode) { }
         public System.DateTimeOffset EndTime { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset StartTime { get { throw null; } }
         public Azure.AI.MetricsAdvisor.AlertQueryTimeMode TimeMode { get { throw null; } }
     }
@@ -53,15 +53,15 @@ public GetAllFeedbackOptions() { }
         public Azure.AI.MetricsAdvisor.Models.FeedbackType? FeedbackType { get { throw null; } set { } }
         public Azure.AI.MetricsAdvisor.Models.DimensionKey Filter { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset? StartTime { get { throw null; } set { } }
         public Azure.AI.MetricsAdvisor.FeedbackQueryTimeMode? TimeMode { get { throw null; } set { } }
     }
     public partial class GetAnomaliesForAlertOptions
     {
         public GetAnomaliesForAlertOptions() { }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetAnomaliesForDetectionConfigurationFilter
     {
@@ -77,15 +77,15 @@ public GetAnomaliesForDetectionConfigurationOptions(System.DateTimeOffset startT
         public System.DateTimeOffset EndTime { get { throw null; } }
         public Azure.AI.MetricsAdvisor.GetAnomaliesForDetectionConfigurationFilter Filter { get { throw null; } set { } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset StartTime { get { throw null; } }
     }
     public partial class GetDataFeedIngestionStatusesOptions
     {
         public GetDataFeedIngestionStatusesOptions(System.DateTimeOffset startTime, System.DateTimeOffset endTime) { }
         public System.DateTimeOffset EndTime { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset StartTime { get { throw null; } }
     }
     public partial class GetDataFeedsFilter
@@ -102,27 +102,27 @@ public partial class GetDataFeedsOptions
         public GetDataFeedsOptions() { }
         public Azure.AI.MetricsAdvisor.GetDataFeedsFilter GetDataFeedsFilter { get { throw null; } set { } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetDimensionValuesOptions
     {
         public GetDimensionValuesOptions() { }
         public string DimensionValueToFilter { get { throw null; } set { } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetHooksOptions
     {
         public GetHooksOptions() { }
         public string HookNameFilter { get { throw null; } set { } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetIncidentsForAlertOptions
     {
         public GetIncidentsForAlertOptions() { }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetIncidentsForDetectionConfigurationOptions
     {
@@ -137,7 +137,7 @@ public partial class GetMetricEnrichmentStatusesOptions
         public GetMetricEnrichmentStatusesOptions(System.DateTimeOffset startTime, System.DateTimeOffset endTime) { }
         public System.DateTimeOffset EndTime { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset StartTime { get { throw null; } }
     }
     public partial class GetMetricSeriesDataOptions
@@ -153,15 +153,15 @@ public GetMetricSeriesDefinitionsOptions(System.DateTimeOffset activeSince) { }
         public System.DateTimeOffset ActiveSince { get { throw null; } }
         public System.Collections.Generic.IDictionary<string, System.Collections.Generic.IList<string>> DimensionCombinationsToFilter { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
     }
     public partial class GetValuesOfDimensionWithAnomaliesOptions
     {
         public GetValuesOfDimensionWithAnomaliesOptions(System.DateTimeOffset startTime, System.DateTimeOffset endTime) { }
         public Azure.AI.MetricsAdvisor.Models.DimensionKey DimensionToFilter { get { throw null; } }
         public System.DateTimeOffset EndTime { get { throw null; } }
         public int? MaxPageSize { get { throw null; } set { } }
-        public int? SkipCount { get { throw null; } set { } }
+        public int? Skip { get { throw null; } set { } }
         public System.DateTimeOffset StartTime { get { throw null; } }
     }
     public partial class MetricsAdvisorClient

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAlertsOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAlertsOptions.cs
@@ -45,7 +45,7 @@ public GetAlertsOptions(DateTimeOffset startTime, DateTimeOffset endTime, AlertQ
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAllFeedbackOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAllFeedbackOptions.cs
@@ -56,7 +56,7 @@ public GetAllFeedbackOptions()
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAnomaliesForAlertOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetAnomaliesForAlertOptions.cs
@@ -22,7 +22,7 @@ public GetAnomaliesForAlertOptions()
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/...etricsadvisor/Azure.AI.MetricsAdvisor/src/GetAnomaliesForDetectionConfigurationOptions.cs b/...etricsadvisor/Azure.AI.MetricsAdvisor/src/GetAnomaliesForDetectionConfigurationOptions.cs
@@ -43,7 +43,7 @@ public GetAnomaliesForDetectionConfigurationOptions(DateTimeOffset startTime, Da
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDataFeedIngestionStatusesOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDataFeedIngestionStatusesOptions.cs
@@ -34,7 +34,7 @@ public GetDataFeedIngestionStatusesOptions(DateTimeOffset startTime, DateTimeOff
         /// <summary>
         /// If set, skips the first set of items returned. This property specifies the count of items to be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDataFeedsOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDataFeedsOptions.cs
@@ -27,7 +27,7 @@ public GetDataFeedsOptions()
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDimensionValuesOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetDimensionValuesOptions.cs
@@ -25,7 +25,7 @@ public GetDimensionValuesOptions()
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetHooksOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetHooksOptions.cs
@@ -20,7 +20,7 @@ public class GetHooksOptions
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetIncidentsForAlertOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetIncidentsForAlertOptions.cs
@@ -23,7 +23,7 @@ public GetIncidentsForAlertOptions()
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetMetricEnrichmentStatusesOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetMetricEnrichmentStatusesOptions.cs
@@ -27,7 +27,7 @@ public GetMetricEnrichmentStatusesOptions(DateTimeOffset startTime, DateTimeOffs
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetMetricSeriesDefinitionsOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetMetricSeriesDefinitionsOptions.cs
@@ -38,7 +38,7 @@ public GetMetricSeriesDefinitionsOptions(DateTimeOffset activeSince)
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetValuesOfDimensionWithAnomaliesOptions.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/GetValuesOfDimensionWithAnomaliesOptions.cs
@@ -44,7 +44,7 @@ public GetValuesOfDimensionWithAnomaliesOptions(DateTimeOffset startTime, DateTi
         /// If set, skips the first set of items returned. This property specifies the amount of items to
         /// be skipped.
         /// </summary>
-        public int? SkipCount { get; set; }
+        public int? Skip { get; set; }
 
         /// <summary>
         /// If set, specifies the maximum limit of items returned in each page of results. Note:

diff --git a/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs b/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
@@ -172,7 +172,7 @@ public virtual AsyncPageable<DataFeed> GetDataFeedsAsync(GetDataFeedsOptions opt
             DataFeedGranularityType? granularityType = options?.GetDataFeedsFilter?.GranularityType;
             DataFeedStatus? status = options?.GetDataFeedsFilter?.Status;
             string creator = options?.GetDataFeedsFilter?.Creator;
-            int? skip = options?.SkipCount;
+            int? skip = options?.Skip;
             int? maxPageSize = options?.MaxPageSize;
 
             async Task<Page<DataFeed>> FirstPageFunc(int? pageSizeHint)
@@ -226,7 +226,7 @@ public virtual Pageable<DataFeed> GetDataFeeds(GetDataFeedsOptions options = def
             DataFeedGranularityType? granularityType = options?.GetDataFeedsFilter?.GranularityType;
             DataFeedStatus? status = options?.GetDataFeedsFilter?.Status;
             string creator = options?.GetDataFeedsFilter?.Creator;
-            int? skip = options?.SkipCount;
+            int? skip = options?.Skip;
             int? maxPageSize = options?.MaxPageSize;
 
             Page<DataFeed> FirstPageFunc(int? pageSizeHint)
@@ -595,7 +595,7 @@ public virtual AsyncPageable<DataFeedIngestionStatus> GetDataFeedIngestionStatus
             Argument.AssertNotNull(options, nameof(options));
 
             IngestionStatusQueryOptions queryOptions = new IngestionStatusQueryOptions(options.StartTime, options.EndTime);
-            int? skip = options.SkipCount;
+            int? skip = options.Skip;
             int? maxPageSize = options.MaxPageSize;
 
             async Task<Page<DataFeedIngestionStatus>> FirstPageFunc(int? pageSizeHint)
@@ -648,7 +648,7 @@ public virtual Pageable<DataFeedIngestionStatus> GetDataFeedIngestionStatuses(st
             Argument.AssertNotNull(options, nameof(options));
 
             IngestionStatusQueryOptions queryOptions = new IngestionStatusQueryOptions(options.StartTime, options.EndTime);
-            int? skip = options.SkipCount;
+            int? skip = options.Skip;
             int? maxPageSize = options.MaxPageSize;
 
             Page<DataFeedIngestionStatus> FirstPageFunc(int? pageSizeHint)
@@ -1672,7 +1672,7 @@ async Task<Page<NotificationHook>> FirstPageFunc(int? pageSizeHint)
 
                 try
                 {
-                    Response<HookList> response = await _serviceRestClient.ListHooksAsync(options?.HookNameFilter, options?.SkipCount, options?.MaxPageSize, cancellationToken).ConfigureAwait(false);
+                    Response<HookList> response = await _serviceRestClient.ListHooksAsync(options?.HookNameFilter, options?.Skip, options?.MaxPageSize, cancellationToken).ConfigureAwait(false);
                     return Page.FromValues(response.Value.Value, response.Value.NextLink, response.GetRawResponse());
                 }
                 catch (Exception e)
@@ -1689,7 +1689,7 @@ async Task<Page<NotificationHook>> NextPageFunc(string nextLink, int? pageSizeHi
 
                 try
                 {
-                    Response<HookList> response = await _serviceRestClient.ListHooksNextPageAsync(nextLink, options?.HookNameFilter, options?.SkipCount, options?.MaxPageSize, cancellationToken).ConfigureAwait(false);
+                    Response<HookList> response = await _serviceRestClient.ListHooksNextPageAsync(nextLink, options?.HookNameFilter, options?.Skip, options?.MaxPageSize, cancellationToken).ConfigureAwait(false);
                     return Page.FromValues(response.Value.Value, response.Value.NextLink, response.GetRawResponse());
                 }
                 catch (Exception e)
@@ -1717,7 +1717,7 @@ Page<NotificationHook> FirstPageFunc(int? pageSizeHint)
 
                 try
                 {
-                    Response<HookList> response = _serviceRestClient.ListHooks(options?.HookNameFilter, options?.SkipCount, options?.MaxPageSize, cancellationToken);
+                    Response<HookList> response = _serviceRestClient.ListHooks(options?.HookNameFilter, options?.Skip, options?.MaxPageSize, cancellationToken);
                     return Page.FromValues(response.Value.Value, response.Value.NextLink, response.GetRawResponse());
                 }
                 catch (Exception e)
@@ -1734,7 +1734,7 @@ Page<NotificationHook> NextPageFunc(string nextLink, int? pageSizeHint)
 
                 try
                 {
-                    Response<HookList> response = _serviceRestClient.ListHooksNextPage(nextLink, options?.HookNameFilter, options?.SkipCount, options?.MaxPageSize, cancellationToken);
+                    Response<HookList> response = _serviceRestClient.ListHooksNextPage(nextLink, options?.HookNameFilter, options?.Skip, options?.MaxPageSize, cancellationToken);
                     return Page.FromValues(response.Value.Value, response.Value.NextLink, response.GetRawResponse());
                 }
                 catch (Exception e)