Merge branch 'main' into feature/storage/stg90base

Azure · May 31, 2023 · 78926c1 · 78926c1
2 parents d3deec9 + 9036b06
commit 78926c1
Show file tree

Hide file tree

Showing 4,024 changed files with 753,031 additions and 206,910 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -262,7 +262,7 @@
 /sdk/communication/Azure.Communication.Sms/                        @RoyHerrod @arifibrahim4
 
 # PRLabel: %Communication - Resource Manager
-/sdk/communication/Azure.ResourceManager.Communication/            @fengzhou-msft @archerzz @ArcturusZhang @Yao725 @ArthurMa1978
+/sdk/communication/Azure.ResourceManager.Communication/            @archerzz @ArcturusZhang @ArthurMa1978
 
 # PRLabel: %Communication - Rooms
 /sdk/communication/Azure.Communication.Rooms/                      @minnieliu @paolamvhz @alexokun @Mrayyan @shwali-msft @allchiang-msft @mikehang-msft
@@ -719,7 +719,7 @@
 /sdk/storsimple/Microsoft.Azure.Management.StorSimple/             @anoobbacker @ganzee @manuaery @patelkunal
 
 # ServiceLabel: %Storsimple %Service Attention
-/sdk/storsimple8000series/Microsoft.Azure.Management.StorSimple8000Series/ @fengzhou-msft @archerzz @ArcturusZhang @Yao725 @ArthurMa1978
+/sdk/storsimple8000series/Microsoft.Azure.Management.StorSimple8000Series/ @archerzz @ArcturusZhang @ArthurMa1978
 
 # ServiceLabel: %Stream Analytics %Service Attention
 /sdk/streamanalytics/Microsoft.Azure.Management.StreamAnalytics/   @atpham256
@@ -770,8 +770,8 @@
 
 # ######## Management Plane ########
 
-/**/*Management*/                                                  @fengzhou-msft @archerzz @ArcturusZhang @Yao725 @ArthurMa1978
-/**/Azure.ResourceManager*/                                        @fengzhou-msft @archerzz @ArcturusZhang @Yao725 @ArthurMa1978
+/**/*Management*/                                                  @archerzz @ArcturusZhang @ArthurMa1978
+/**/Azure.ResourceManager*/                                        @archerzz @ArcturusZhang @ArthurMa1978
 
 # Reviewers to double check any API changes
 /sdk/**/api/                                                       @KrzysztofCwalina @tg-msft
@@ -788,7 +788,13 @@
 # ######## DPG ########
 
 # Onboarding Documentation and Quickstarts
-/doc/Data\ Plane\ Code\ Generation                                 @chunyu3 @pshao25 @fengzhou-msft @lirenhe @annelo-msft
+/doc/Data\ Plane\ Code\ Generation                                 @chunyu3 @pshao25 @lirenhe @annelo-msft
 
 # Client generation tooling
 /eng/templates/Azure.ServiceTemplate.Template                      @chunyu3 @lirenhe
+
+# PRLabel: %Cognitive - Content Safety
+/sdk/contentsafety/												   @bowgong @mengaims
+
+# ServiceLabel: %Cognitive - Content Safety %Service Attention
+/sdk/contentsafety/Azure.AI.ContentSafety/                     	   @bowgong @mengaims
diff --git a/.vscode/cspell.json b/.vscode/cspell.json
@@ -46,7 +46,9 @@
     "sdk/objectanchors/*/api/*.cs",
     "sdk/purview/*/api/*.cs",
     "sdk/remoterendering/*/api/*.cs",
-    "sdk/videoanalyzer/*/api/*.cs"
+    "sdk/videoanalyzer/*/api/*.cs",
+    "sdk/newrelicobservability/*/api/*.cs",
+    "sdk/paloaltonetworks.ngfw/*/api/*.cs"
   ],
   // cspell is not case sensitive
   // Sort words alphabetically to make this list easier to use
@@ -69,6 +71,7 @@
     "fhir",
     "finalizer",
     "finalizers",
+    "hnsw",
     "illumos",
     "interventional",
     "ints",
@@ -99,6 +102,7 @@
     "unformattable",
     "unhold",
     "uninstrumented",
+    "vcpus",
     "vmss",
     "vnet",
     "westus",
@@ -585,6 +589,23 @@
         "Latam"
       ]
     },
+    {
+      "filename": "**/sdk/networkcloud/**/*.cs",
+      "words": [
+        "Reimage",
+        "Uncordon",
+        "Uncordoned",
+        "Ipam",
+        "Virtio",
+        "nics",
+        "Lldp",
+        "Nics",
+        "Dpdk",
+        "Sriov",
+        "Sata",
+        "Uefi"
+      ]
+    },
     {
       "filename": "**/sdk/keyvault/**/*.cs",
       "words": [

diff --git a/...eCodeGeneration/Add_ProtocolMethods_In_Gen1_Convenience_Client_Generated_SDK.md b/...eCodeGeneration/Add_ProtocolMethods_In_Gen1_Convenience_Client_Generated_SDK.md
@@ -49,7 +49,7 @@ internal partial class TableRestClient
             case 204:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw await ClientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
+                throw new RequestFailedException(message.Response);
         }
     }
 
@@ -68,7 +68,7 @@ internal partial class TableRestClient
             case 204:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw ClientDiagnostics.CreateRequestFailedException(message.Response);
+                throw new RequestFailedException(message.Response);
         }
     }
     // ...
@@ -110,7 +110,7 @@ internal partial class ServiceRestClient
             case 202:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw await ClientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
+                throw new RequestFailedException(message.Response);
         }
     }
 
@@ -129,7 +129,7 @@ internal partial class ServiceRestClient
             case 202:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw ClientDiagnostics.CreateRequestFailedException(message.Response);
+                throw new RequestFailedException(message.Response);
         }
     }
     // ...
@@ -204,7 +204,7 @@ internal partial class TableRestClient
             case 204:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw await ClientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
+                throw new RequestFailedException(message.Response);
         }
     }
 
@@ -223,7 +223,7 @@ internal partial class TableRestClient
             case 204:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw ClientDiagnostics.CreateRequestFailedException(message.Response);
+                throw new RequestFailedException(message.Response);
         }
     }
 +
@@ -301,7 +301,7 @@ internal partial class ServiceRestClient
             case 202:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw await ClientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
+                throw new RequestFailedException(message.Response);
         }
     }
 
@@ -320,7 +320,7 @@ internal partial class ServiceRestClient
             case 202:
                 return ResponseWithHeaders.FromValue(headers, message.Response);
             default:
-                throw ClientDiagnostics.CreateRequestFailedException(message.Response);
+                throw new RequestFailedException(message.Response);
         }
     }
 +

diff --git a/doc/DataPlaneCodeGeneration/AzureSDKCodeGeneration_DataPlane_Quickstart.md b/doc/DataPlaneCodeGeneration/AzureSDKCodeGeneration_DataPlane_Quickstart.md
@@ -18,7 +18,7 @@ We will generate an SDK under the SDK project folder of `azure-sdk-for-net`.
 
 You can update `tsp-location.yaml` under sdk project folder to set the typespec project.
 
-You can refer to the [tsp-location.yaml](https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/Typespec-Project-Scripts.md#tsp-locationyaml) which describes the supported properties in the file.
+You can refer to the [tsp-location.yaml](https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/TypeSpec-Project-Scripts.md#tsp-locationyaml) which describes the supported properties in the file.
 
 ### Generate Code
 
@@ -39,14 +39,14 @@ Code review happens on 2 places.
 
 One is the usual GitHub pull request, for developers.
 
-Another is the [apiview](https://apiview.dev/), for architects. GitHub pull request (PR) should automatically trigger the apiview. If this does not happen, please help to file an issue in [azure-sdk-tools](https://github.com/azure/azure-sdk-tools) to report the failure. 
+Another is the [apiview](https://apiview.dev/), for architects. GitHub pull request (PR) should automatically trigger the apiview. If this does not happen, please help to file an issue in [azure-sdk-tools](https://github.com/azure/azure-sdk-tools) to report the failure.
 And you can upload one manually:
 
  - Build the SDK, Run `dotnet pack` to create SDK package.
  - Login apiview with GitHub account.
  - Click "Create + review" at bottom-right corner.
  - "Browse" and upload .nupkg (e.g. /home/azure-sdk-for-net/artifacts/package/Debug/Azure.AI.AnomalyDetector/Azure.AI.AnomalyDetector.3.0.0-alpha.20230331.1.nupkg), and comment the result apiview link in the PR.
-  
+
 **Comment @Azure/dpg-devs for awareness in PR to loop in SDK developers for review.**
 
 ## Package Release

diff --git a/doc/DataPlaneCodeGeneration/AzureSDKGeneration_Prerequistites.md b/doc/DataPlaneCodeGeneration/AzureSDKGeneration_Prerequistites.md
@@ -12,7 +12,7 @@
 
 ## Set up TypeSpec project
 
-Make sure you have typespec project in API specification repo, e.g. [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs) repo or you can follow [TypeSpec Getting Started](https://github.com/microsoft/typespec/#using-node--npm) to initialize your typespec project, and refer to [TypeSpec Structure Guidelines](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/cadl-structure-guidelines.md) to configure your typespec project.
+Make sure you have typespec project in API specification repo, e.g. [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs) repo or you can follow [TypeSpec Getting Started](https://github.com/microsoft/typespec/#using-node--npm) to initialize your typespec project, and refer to [TypeSpec Structure Guidelines](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/typespec-structure-guidelines.md) to configure your typespec project.
 
 ## Set up SDK Project Folder
 

diff --git a/eng/CredScanSuppression.json b/eng/CredScanSuppression.json
@@ -61,13 +61,22 @@
                 "sdk/identity/Azure.Identity/tests/Data/cert.pem",
                 "sdk/identity/Azure.Identity/tests/Data/mock-arc-mi-key.key",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/PemReaderTests.Keys.cs",
+                "sdk/locationbasedservices/Microsoft.Azure.Management.LocationBasedServices/tests/Tests/LocationBasedServicesAccountTests.cs",
                 "sdk/storage/Azure.Storage.Common/tests/Shared/azurite_cert.pem",
                 "sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/tests/cert.pem"
             ],
             "_justification": "Files contain private keys used by test code."
         },
         {
             "file":[
+                "sdk/automation/Microsoft.Azure.Management.Automation/tests/SessionRecords/AutomationTest/CanCreateUpdateDeleteWebhook.json",
+                "sdk/containerservice/Azure.ResourceManager.ContainerService/tests/SessionRecords/ContainerServiceCollectionTests/GetCredentials().json",
+                "sdk/containerservice/Azure.ResourceManager.ContainerService/tests/SessionRecords/ContainerServiceCollectionTests/GetCredentials()Async.json",
+                "sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/SessionRecords/ContainerServiceTests/ContainerListClusterAdminCredentialsTest.json",
+                "sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/SessionRecords/ContainerServiceTests/ContainerServiceCreateManagedServiceTest.json",
+                "sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/SessionRecords/ContainerServiceTests/ContainerServiceDeleteServiceTest.json",
+                "sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/SessionRecords/ContainerServiceTests/ContainerServiceGetCredentialsTest.json",
+                "sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/SessionRecords/ContainerServiceTests/ContainerServiceUpdateServiceTest.json",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/DownloadECDsaCertificateSignLocalVerifyRemote(application%x-pem-file,P-256).json",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/DownloadECDsaCertificateSignLocalVerifyRemote(application%x-pem-file,P-256)Async.json",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/DownloadECDsaCertificateSignLocalVerifyRemote(application%x-pem-file,P-384).json",
@@ -87,12 +96,25 @@
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/VerifyImportCertificatePem.json",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/VerifyImportCertificatePemAsync.json",
                 "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/VerifyImportCertificatePemWithoutIssuer.json",
-                "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/VerifyImportCertificatePemWithoutIssuerAsync.json"
-            ],
-            "_justification": "Files contain ephemeral keys or certificates used by test code during playback."
-        },
-        {
-            "file":[
+                "sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/SessionRecords/CertificateClientLiveTests/VerifyImportCertificatePemWithoutIssuerAsync.json",
+                "sdk/hybridkubernetes/Microsoft.Azure.Management.Kubernetes/tests/SessionRecords/KubernetesServiceTests/ListClusterUserCredentialCSPAADTest.json",
+                "sdk/hybridkubernetes/Microsoft.Azure.Management.Kubernetes/tests/SessionRecords/KubernetesServiceTests/ListClusterUserCredentialCSPTokenTest.json",
+                "sdk/locationbasedservices/Microsoft.Azure.Management.LocationBasedServices/tests/SessionRecords/LocationBasedServicesServicesAccountTests/LocationBasedServicesAccountListKeysTest.json",
+                "sdk/locationbasedservices/Microsoft.Azure.Management.LocationBasedServices/tests/SessionRecords/LocationBasedServicesServicesAccountTests/LocationBasedServicesAccountRegenerateKeyTest.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/CheckSystemServicesUpdatesAvailable.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/CreateCluster.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/DeleteAllResources.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/DeleteCluster.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/GetCluster.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/ListClustersBySubscriptionId.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/ListClustersInResourceGroup.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/ListKeys.json",
+                "sdk/machinelearningcompute/Microsoft.Azure.Management.MachineLearningCompute/tests/SessionRecords/MachineLearningComputeTests/UpdateSystemServices.json",
+                "sdk/maps/Microsoft.Azure.Management.Maps/tests/SessionRecords/MapsServicesAccountTests/MapsAccountListKeysTest.json",
+                "sdk/maps/Microsoft.Azure.Management.Maps/tests/SessionRecords/MapsServicesAccountTests/MapsAccountRegenerateKeyTest.json",
+                "sdk/mediaservices/Microsoft.Azure.Management.Media/tests/SessionRecords/LiveEventTests/LiveEventComboTest.json",
+                "sdk/mediaservices/Microsoft.Azure.Management.Media/tests/SessionRecords/LiveOutputTests/LiveOutputComboTest.json",
+                "sdk/scheduler/Microsoft.Azure.Management.Scheduler/tests/SessionRecords/JobTests/Scenario_JobCreateHttpJobWithOAuth.json",
                 "sdk/sqlvirtualmachine/Azure.ResourceManager.SqlVirtualMachine/tests/SessionRecords/SqlVmGroupTests/TestCreateGetDeleteSqlVirtualMachineGroup().json",
                 "sdk/sqlvirtualmachine/Azure.ResourceManager.SqlVirtualMachine/tests/SessionRecords/SqlVmGroupTests/TestCreateGetDeleteSqlVirtualMachineGroup()Async.json",
                 "sdk/sqlvirtualmachine/Azure.ResourceManager.SqlVirtualMachine/tests/SessionRecords/SqlVmGroupTests/TestCreateUpdateGetSqlVirtualMachineGroup().json",
@@ -122,10 +144,10 @@
         },
         {
             "file":[
-                "sdk/containerservice/Azure.ResourceManager.ContainerService/tests/SessionRecords/ContainerServiceCollectionTests/GetCredentials().json",
-                "sdk/containerservice/Azure.ResourceManager.ContainerService/tests/SessionRecords/ContainerServiceCollectionTests/GetCredentials()Async.json"
+                "sdk/deploymentmanager/Azure.ResourceManager.DeploymentManager/samples/Generated/Samples/Sample_StepResource.cs",
+                "sdk/deploymentmanager/Azure.ResourceManager.DeploymentManager/samples/Generated/Samples/Sample_StepResourceCollection.cs"
             ],
-            "_justification": "Files contain ephemeral keys or certificates used by test code during playback."
+            "_justification": "Fake secret used by auto generated samples."
         }
     ]
 }