Skip to content

Commit

Permalink
[ACS][GA1] Clean Commit (#36550)
Browse files Browse the repository at this point in the history
* clean commit

* Updated comments on start recording options

---------

Co-authored-by: Min Woo Lee 🧊 <77083090+minwoolee-ms@users.noreply.github.com>
  • Loading branch information
2 people authored and vivekmore-msft committed Aug 4, 2023
1 parent e8f2033 commit 7934196
Show file tree
Hide file tree
Showing 188 changed files with 1,177 additions and 7,160 deletions.
20 changes: 5 additions & 15 deletions sdk/communication/Azure.Communication.CallAutomation/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
# Release History

## 1.1.0-beta.1 (Unreleased)
## 1.0.0 (2023-05-29)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes

## 1.0.0 (2023-06-14)

### Features Added
### Features Added
- Outbound calls can now be created without providing a User Identifier. This value can be specified in the CallAutomationClientOption if desired.
- AnswerCall now accepts OperationContext.
- Calls can be answered by a specific communication identifier user.
Expand All @@ -22,9 +12,9 @@
- StartRecording now accepts ChannelAffinity.
- Added EventProcessor, an easy and powerful way to handle Call Automation events. See README for details.

### Breaking Changes
- AddParticipant and RemoveParticipant now only accept one participant at a time.
- CallSource has been flattened out.
### Breaking Changes
- AddParticipant and RemoveParticipant now only accept one participant at a time.
- CallSource has been flattened out.
- CallInvite model replaces previous models for handling outbound calls.

## 1.0.0-beta.1 (2022-11-07)
Expand Down
12 changes: 6 additions & 6 deletions sdk/communication/Azure.Communication.CallAutomation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ public IActionResult OnMidConnectionCallBackEvent([FromBody] CloudEvent[] events
# cast the event into a ParticipantUpdated event and do something with it. Eg. iterate through the participants
ParticipantsUpdated updatedEvent = (ParticipantsUpdated)ev;
break;
case AddParticipantsSucceeded ev:
# logic to handle an AddParticipantsSucceeded event
case AddParticipantSucceeded ev:
# logic to handle an AddParticipantSucceeded event
break;
case AddParticipantsFailed ev:
# logic to handle an AddParticipantsFailed event
case AddParticipantFailed ev:
# logic to handle an AddParticipantFailed event
break;
case CallTransferAccepted ev:
# logic to handle CallTransferAccepted event
Expand Down Expand Up @@ -155,10 +155,10 @@ CancellationToken token = cts.Token;
try
{
// this will wait until CreateCall is completed or Timesout!
CreateCallEventResult eventResult = await createCallResult.WaitForEventAsync(token);
CreateCallEventResult eventResult = await createCallResult.WaitForEventProcessorAsync(token);

// Once this is recieved, you know the call is now connected.
CallConnected returnedEvent = eventResult.SuccessEvent;
CallConnected returnedEvent = eventResult.SuccessResult;

// ...Do more actions, such as Play or AddParticipant, since the call is established...
}
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
Microsoft Azure Communication Call Automation quickstart - https://learn.microsoft.com/azure/communication-services/quickstarts/voice-video-calling/callflows-for-customer-interactions?pivots=programming-language-csharp
</Description>
<AssemblyTitle>Azure Communication CallAutomation Service</AssemblyTitle>
<Version>1.1.0-beta.1</Version>
<Version>1.0.0</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<PackageTags>Microsoft Azure Communication CallAutomation Service;Microsoft;Azure;Azure Communication Service;Azure Communication CallAutomation Service;Calling;Communication;$(PackageCommonTags)</PackageTags>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
Expand All @@ -28,8 +28,7 @@
<Compile Include="$(AzureCoreSharedSources)CancellationHelper.cs" LinkBase="Shared" />
</ItemGroup>
<ItemGroup>
<!-- <PackageReference Include="Azure.Core" /> -->
<ProjectReference Include="..\..\..\core\Azure.Core\src\Azure.Core.csproj" />
<PackageReference Include="Azure.Core" />
<PackageReference Include="Azure.Communication.Common" />
<PackageReference Include="System.Text.Json" />
</ItemGroup>
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class CallAutomationClientOptions : ClientOptions
/// <summary>
/// The latest version of the CallAutomation service.
/// </summary>
internal const ServiceVersion LatestVersion = ServiceVersion.V2023_01_15_Preview;
internal const ServiceVersion LatestVersion = ServiceVersion.V2023_03_06;

internal string ApiVersion { get; }

Expand All @@ -32,7 +32,7 @@ public CallAutomationClientOptions(ServiceVersion version = LatestVersion)
{
ApiVersion = version switch
{
ServiceVersion.V2023_01_15_Preview => "2023-01-15-preview",
ServiceVersion.V2023_03_06 => "2023-03-06",
_ => throw new ArgumentOutOfRangeException(nameof(version)),
};
}
Expand All @@ -43,10 +43,10 @@ public CallAutomationClientOptions(ServiceVersion version = LatestVersion)
public enum ServiceVersion
{
/// <summary>
/// The Beta of the CallAutomation service.
/// The GA1 of the CallAutomation service.
/// </summary>
#pragma warning disable CA1707 // Identifiers should not contain underscores
V2023_01_15_Preview = 1
V2023_03_06 = 1
#pragma warning restore CA1707 // Identifiers should not contain underscores
}
}
Expand Down

This file was deleted.

Loading

0 comments on commit 7934196

Please sign in to comment.