fix(playwrighttesting): no auth error when scalable scenario is disab…

…led (#47050) Co-authored-by: Siddharth Singha Roy <ssingharoy@microsoft.com>
Azure · Nov 11, 2024 · d9e0d05 · d9e0d05
1 parent 94939dc
commit d9e0d05
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/...ghttesting/Azure.Developer.MicrosoftPlaywrightTesting.NUnit/src/PlaywrightServiceNUnit.cs b/...ghttesting/Azure.Developer.MicrosoftPlaywrightTesting.NUnit/src/PlaywrightServiceNUnit.cs
@@ -5,7 +5,7 @@
 using NUnit.Framework;
 using System.Threading.Tasks;
 using System.Runtime.InteropServices;
-using System.Threading;
+using System;
 using Azure.Developer.MicrosoftPlaywrightTesting.TestLogger;
 
 namespace Azure.Developer.MicrosoftPlaywrightTesting.NUnit;
@@ -45,6 +45,10 @@ public PlaywrightServiceNUnit(TokenCredential? credential = null)
     [OneTimeSetUp]
     public async Task SetupAsync()
     {
+        if (!UseCloudHostedBrowsers)
+            return;
+        TestContext.Progress.WriteLine("\nRunning tests using Microsoft Playwright Testing service.\n");
+
         await InitializeAsync().ConfigureAwait(false);
     }
 

diff --git a/...ghttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/PlaywrightService.cs b/...ghttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/PlaywrightService.cs
@@ -145,6 +145,7 @@ public async Task InitializeAsync(CancellationToken cancellationToken = default)
             // Since playwright-dotnet checks PLAYWRIGHT_SERVICE_ACCESS_TOKEN and PLAYWRIGHT_SERVICE_URL to be set, remove PLAYWRIGHT_SERVICE_URL so that tests are run locally.
             // If customers use GetConnectOptionsAsync, after setting disableScalableExecution, an error will be thrown.
             Environment.SetEnvironmentVariable(ServiceEnvironmentVariable.PlaywrightServiceUri, null);
+            return;
         }
         // If default auth mechanism is Access token and token is available in the environment variable, no need to setup rotation handler
         if (ServiceAuth == ServiceAuthType.AccessToken)

diff --git a/...ing/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/PlaywrightServiceTests.cs b/...ing/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/PlaywrightServiceTests.cs
@@ -185,9 +185,9 @@ public void Initialize_WhenDefaultAuthIsEntraIdAccessTokenAndAccessTokenEnvironm
         Assert.That(Environment.GetEnvironmentVariable(ServiceEnvironmentVariable.PlaywrightServiceUri), Is.Not.Null);
 
         service.InitializeAsync().Wait();
-        defaultAzureCredentialMock.Verify(x => x.GetTokenAsync(It.IsAny<TokenRequestContext>(), It.IsAny<CancellationToken>()), Times.Once);
+        defaultAzureCredentialMock.Verify(x => x.GetTokenAsync(It.IsAny<TokenRequestContext>(), It.IsAny<CancellationToken>()), Times.Never);
 
-        service.RotationTimer!.Dispose();
+        Assert.That(service.RotationTimer, Is.Null);
 
         Assert.That(Environment.GetEnvironmentVariable(ServiceEnvironmentVariable.PlaywrightServiceUri), Is.Null);
     }