Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate LocalCryptographyClients using server output #16713

Closed
heaths opened this issue Nov 7, 2020 · 1 comment · Fixed by #18902
Closed

Validate LocalCryptographyClients using server output #16713

heaths opened this issue Nov 7, 2020 · 1 comment · Fixed by #18902
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] March

Comments

@heaths
Copy link
Member

heaths commented Nov 7, 2020 •
edited
Loading

The LocalCryptographyClient is round-tripping operations through supported algorithm, which provides good coverage for the client; however, it will also be good to verify with server-generated data from the CryptographyClient that we are indeed getting the same results back the server would use (within reason - obviously RSA operations will vary).
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Nov 7, 2020
@heaths heaths added this to the [2021] February milestone Nov 7, 2020
@heaths heaths self-assigned this Nov 7, 2020
@heaths heaths modified the milestones: [2021] February, [2021] March Feb 6, 2021
@heaths
Copy link
Member Author

heaths commented Feb 18, 2021

This is a bit of a stretch-goal to doubly-validate, but we have pretty good coverage already.

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Feb 20, 2021
@heaths
Add test coverage for MHSM and local cryptography
6e2c699 
Resolves Azure#16713
Resolves Azure#18864

Temporarily works around Azure#18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.
@heaths heaths mentioned this issue Feb 20, 2021
Merged
heaths added a commit that referenced this issue Feb 22, 2021
@heaths
Add test coverage for MHSM and local cryptography (#18902)
dfbb155 
* Add test coverage for MHSM and local cryptography

Resolves #16713
Resolves #18864

Temporarily works around #18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.

* Add comments explaining CreateRSAProvider private method

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] March
Development

Successfully merging a pull request may close this issue.

Add test coverage for MHSM and local cryptography heaths/azure-sdk-for-net
1 participant
@heaths