Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Key Vault SDK 4.2 APIs #20926

Closed
6 tasks done
heaths opened this issue May 7, 2021 · 0 comments · Fixed by #20968
Closed
6 tasks done

Unify Key Vault SDK 4.2 APIs #20926

heaths opened this issue May 7, 2021 · 0 comments · Fixed by #20968
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] June

Comments

@heaths
Copy link
Member

heaths commented May 7, 2021 •
edited
Loading

  • Unify parameters for KeyVaultAccessControlClient.CreateOrUpdateRoleDefinition(). See set_role_definition for Key Vault should reorder parameters azure-sdk-for-python#18579.
  • Preface BackupOperation and RestoreOperation with "KeyVault" (like Java).
  • Use KeyVaultSelectiveKeyRestoreOperation and related prefixes where appropriate.
  • Move all types from within ".Models" to main namespace.
  • roleScope should preceed roleDefinitionName in DeleteRoleDefinition and GetRoleDefinition. Not only is this consistent with other tier 1 languages, but makes sense even within .NET. Methods for role assignments define the roleScope first, and any Get method defines it first as well.
  • Remove "WithScope" from KeyVaultRoleAssignPropertiesWithScope for consistency.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels May 7, 2021
@heaths heaths added this to the [2021] June milestone May 7, 2021
@heaths heaths self-assigned this May 7, 2021
@heaths heaths changed the title Unify on createOrUpdateRoleDefinition API Unify Key Vault SDK 4.2 APIs May 8, 2021
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 11, 2021
@heaths
Rename operation classes and .models namespace
1297823 
Partly fixes Azure#20926
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 11, 2021
@heaths
Change order of role definition methods
bb7f7b7 
Partly fixes Azure#20926
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 11, 2021
@heaths
Use commit 1e2c9f3e for Administration package
5835ac7 
Partly fixes Azure#20926
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 11, 2021
@heaths
Create CreateOrUpdateRoleDefinitionOptions
365da9e 
Partly fixes Azure#20926
@heaths heaths mentioned this issue May 11, 2021
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 11, 2021
@heaths
Rename KeyVaultRoleAssignmentPropertiesWithScope
f1cf64f 
Partly fixes Azure#20926
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Oct 10, 2022
@msyyc
CodeGen from PR 20926 in Azure/azure-rest-api-specs
d107a05 
[Network] Update readme.python.md (Azure#20926)

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

Unify Key Vault Administration APIs heaths/azure-sdk-for-net
1 participant
@heaths