[BUG] Missing deserialization of LeaseStatus in Azure.Storage.Blobs.BlobExtensions.ToBlobDownloadStreamingResult

[egraff]

Describe the bug
Azure.Storage.Blobs.BlobExtensions.ToBlobDownloadStreamingResult() does not populate the BlobDownloadDetails's LeaseState from the response headers object. It does set the LeaseState and LeaseDuration:

azure-sdk-for-net/sdk/storage/Azure.Storage.Blobs/src/BlobExtensions.cs

Lines 872 to 873 in 0c9f9ef

	LeaseDuration = response.Headers.LeaseDuration ?? LeaseDurationType.Infinite,
	LeaseState = response.Headers.LeaseState.GetValueOrDefault(),

but is missing something like:

LeaseStatus = response.Headers.LeaseStatus.GetValueOrDefault()

This is a regression introduced in 1814567.

As a result of this, the BlobDownloadDetails you get after doing e.g. BlobBaseClient.DownloadAsync() returns a LeaseStatus that is always equal to LeaseStatus.Locked (since this is the default value of the enum).

Expected behavior
The BlobDownloadDetails should contain a LeaseStatus that reflects the value of the x-ms-lease-status header from the "Get Blob" HTTP response.

Actual behavior (include Exception or Stack Trace)
BlobDownloadDetails always contains a LeaseStatus equal to LeaseStatus.Locked.

To Reproduce

/* Pseudo-code */
BaseBlobClient blobClient = GetClientForUnlockedBlob();
Response<BlobDownloadInfo> downloadResponse = await blobClient.DownloadAsync().ConfigureAwait(false);
Assert.That(downloadResponse.Value.Details.LeaseStatus, Is.EqualTo(LeaseStatus.Unlocked));

Environment:

• Name and version of the Library package used: Azure.Storage.Blobs 12.9.0 (issue is not present in Azure.Storage.Blobs 12.8.4)

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details

---

Describe the bug
Azure.Storage.Blobs.BlobExtensions.ToBlobDownloadStreamingResult() does not populate the BlobDownloadDetails's LeaseState from the response headers object. It does set the LeaseState and LeaseDuration:

azure-sdk-for-net/sdk/storage/Azure.Storage.Blobs/src/BlobExtensions.cs

Lines 872 to 873 in 0c9f9ef

	LeaseDuration = response.Headers.LeaseDuration ?? LeaseDurationType.Infinite,
	LeaseState = response.Headers.LeaseState.GetValueOrDefault(),

but is missing something like:

LeaseStatus = response.Headers.LeaseStatus.GetValueOrDefault()

This is a regression introduced in 1814567.

As a result of this, the BlobDownloadDetails you get after doing e.g. BlobBaseClient.DownloadAsync() returns a LeaseStatus that is always equal to LeaseStatus.Locked (since this is the default value of the enum).

Expected behavior
The BlobDownloadDetails should contain a LeaseStatus that reflects the value of the x-ms-lease-status header from the "Get Blob" HTTP response.

Actual behavior (include Exception or Stack Trace)
BlobDownloadDetails always contains a LeaseStatus equal to LeaseStatus.Locked.

To Reproduce

/* Pseudo-code */
BaseBlobClient blobClient = GetClientForUnlockedBlob();
Response<BlobDownloadInfo> downloadResponse = await blobClient.DownloadAsync().ConfigureAwait(false);
Assert.That(downloadResponse.Value.Details.LeaseStatus, Is.EqualTo(LeaseStatus.Unlocked));

Environment:

• Name and version of the Library package used: Azure.Storage.Blobs 12.9.0 (issue is not present in Azure.Storage.Blobs 12.8.4)

Author:	egraff
Assignees:	-
Labels:	Client, Service Attention, Storage, customer-reported, needs-team-attention, needs-triage, question
Milestone:	-

[amishra-dev]

@seanmcc-msft Sean, could you please look at this one.

[seanmcc-msft]

Hi @egraff, I can repo this issue, and will work to address it shortly.

Thanks for reporting this!

-Sean