-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Azure.Monitor.OpenTelemetry.Exporter tests fail under net7.0 #33403
Comments
@heaths you mentioned a few tests, but only quoted the one "VerifyRequestTelemetry". |
Tests include:
|
These are the integration tests; the unit test invokes a request to a web app and verify that a valid RequestTelemetry is generated. These tests are failing because the request fails to invoke. Tests fail on this line: This affects net7 only, and the fix is to update the dependency:
I want to avoid conflicts, so I'll wait for Heath's PR to merge and then I'll submit a PR with the fix. :) |
I plan to merge EOW this week or early next week after our normal shipping cycle. |
Please be sure to remove the |
* Drop netcoreapp3.1, add net7.0 support Resolves #32596. With netcoreapp3.1 falling out of support soon, we're upgrading to net7.0, net6.0, and, on Windows, net461. * Resolve PR comments and fix build break * Tweak platform monikers * Upgrade to .NET 7.0.101 SDK Required for microsoft/vstest#4014 fix * Drop unnecessary runtimes from .vsconfig * Skip Monitor tests failing under net7.0 Relates to #33403 * Resolve track 1 management plane issues on net7.0 * Resolve Key Vault issues after upgrade to net7.0 * Use different platform guard for management plane * Resolve PR feedback
@TimothyMothra my PR to build tests for |
When testing #32814 I found a few tests for
Azure.Monitor.OpenTelemetry.Exporter
are failing only under net7.0 with an error like:From similar reports on GitHub, this most often seems to be a case where code assumed some value it's adding to headers was non-empty, and the fix has been to make sure the value to add (perhaps part of a header value collection) isn't empty. However, during initial investigation I found no code in sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src that could convevably add an empty header name or value, nor anything in the related tests folder. I fear this may be some middleware that hopefully just needs to be updated.
The text was updated successfully, but these errors were encountered: