Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP Foundation (Links) #7188

Closed
jsquire opened this issue Aug 7, 2019 · 0 comments
Closed

AMQP Foundation (Links) #7188

jsquire opened this issue Aug 7, 2019 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Aug 7, 2019

Summary

The current track two implementation delegates to an embedded copy of the track one library as its transport layer. This approach was chosen as a temporary measure to speed development and allow the track two API surface to be modeled and released for feedback more quickly. It requires translation between types in the track two context and those in track one, resulting in more allocations, higher resource use, and a less efficient communication pipeline with the Event Hubs service.

In order to provide the best experience, the track two library will be implementing its own AMQP transport layer consistent with the abstractions in place, consistent with the track two goals, and adhering to the current design principles and standards.

Scope of Work

  • Create the base foundation for the AMQP link management, including types needed for creation and management of AMQP links and those responsible for managing credentials and authorization used with the links.

  • Create new tests that cover the implementation surface and validate functionality.

  • Update existing tests as needed to incorporate changes.

Out of Scope

  • Types related to AMQP connection and session management.

  • Transport abstraction types, including the AmqpEventHubClient, AmqpEventHubProducer, and AmqpEventHubConsumer

Success Criteria

  • The base foundation for creating, managing, and using AMQP links as part of a transport layer specific to the track two Event Hubs client library has been implemented

  • The implementation has extensive test coverage and those tests pass consistently and reliably with deterministic results.

@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Aug 7, 2019
@jsquire jsquire self-assigned this Aug 7, 2019
@jsquire jsquire added this to the Sprint 158 milestone Aug 7, 2019
@jsquire jsquire modified the milestones: Sprint 158, Sprint 159 Sep 5, 2019
@jsquire jsquire modified the milestones: Sprint 159, Sprint 160 Oct 3, 2019
@jsquire jsquire closed this as completed Oct 4, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

1 participant