[Event Hubs Client] Track Two: Fourth Preview (AMQP Receiver Scope) #7903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
kinelski,
AlexGhiondea,
conniey,
ramya-rao-a,
serkantkaraca,
ShivangiReja,
yunhaoling,
YijunXieMS,
chradek and
srnagar
jsquire
commented
Oct 3, 2019
Comment on lines
-32
to
-34
| <ItemGroup> | ||
| <None Remove="Azure.Messaging.EventHubs.Reference.props" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
This is no longer a thing; it was added (and removed) as part of the checkpoint store package work.
jsquire
commented
Oct 3, 2019
Comment on lines
-1865
to
-1891
| /// <summary> | ||
| /// Verifies that the <see cref="EventHubConsumer" /> is able to | ||
| /// connect to the Event Hubs service and perform operations. | ||
| /// </summary> | ||
| /// | ||
| [Test] | ||
| [Ignore("Expected behavior currently under discussion")] | ||
| public async Task ConsumerCanReceiveWhenClientIsClosed() | ||
| { | ||
| await using (EventHubScope scope = await EventHubScope.CreateAsync(1)) | ||
| { | ||
| var connectionString = TestEnvironment.BuildConnectionStringForEventHub(scope.EventHubName); | ||
|
|
||
| await using (var client = new EventHubClient(connectionString)) | ||
| { | ||
| var partition = (await client.GetPartitionIdsAsync()).First(); | ||
|
|
||
| await using (EventHubConsumer consumer = client.CreateConsumer(EventHubConsumer.DefaultConsumerGroupName, partition, EventPosition.Latest)) | ||
| { | ||
| client.Close(); | ||
|
|
||
| Assert.That(async () => await consumer.ReceiveAsync(1, TimeSpan.Zero), Throws.Nothing); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Per discussion, the service team requests that we have a 1:1 relationship between the client and AMQP connections. The client owns the connection, so when it is closed, any child consumer/producer will no longer be able to operate, by design.
jsquire
commented
Oct 3, 2019
Comment on lines
-971
to
-994
| /// <summary> | ||
| /// Verifies that the <see cref="EventHubProducer" /> is able to | ||
| /// connect to the Event Hubs service and perform operations. | ||
| /// </summary> | ||
| /// | ||
| [Test] | ||
| [Ignore("Expected behavior currently under discussion")] | ||
| public async Task ProducerCanSendWhenClientIsClosed() | ||
| { | ||
| await using (EventHubScope scope = await EventHubScope.CreateAsync(1)) | ||
| { | ||
| var connectionString = TestEnvironment.BuildConnectionStringForEventHub(scope.EventHubName); | ||
|
|
||
| await using (var client = new EventHubClient(connectionString)) | ||
| await using (EventHubProducer producer = client.CreateProducer()) | ||
| { | ||
| client.Close(); | ||
|
|
||
| var events = new EventData(Encoding.UTF8.GetBytes("Do not delete me!")); | ||
| Assert.That(async () => await producer.SendAsync(events), Throws.Nothing); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Per discussion, the service team requests that we have a 1:1 relationship between the client and AMQP connections. The client owns the connection, so when it is closed, any child consumer/producer will no longer be able to operate, by design.
kinelski
reviewed
Oct 3, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Amqp/AmqpProperty.cs
Outdated
Show resolved
Hide resolved
kinelski
reviewed
Oct 3, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Amqp/AmqpEventHubConsumer.cs
Outdated
Show resolved
Hide resolved
jsquire
force-pushed
the
eventhubs/amqp-scope
branch
from
919e8bb to
a81193b
Compare
kinelski
reviewed
Oct 3, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Diagnostics/EventHubsEventSource.cs
Outdated
Show resolved
Hide resolved
kinelski
reviewed
Oct 3, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Amqp/AmqpConnectionScope.cs
Outdated
Show resolved
Hide resolved
jsquire
force-pushed
the
eventhubs/amqp-scope
branch
from
a81193b to
4718f51
Compare
AMQP Infrastructure
- Large refactoring to AMQP scope for a more consistent structure and better
naming.
- Fleshed out AMQP filtering, to allow setting the position for reading within
the partition.
- Implemenation of parent/child relationship between the AMQP scope and the
connection and links that are bound to it. Disposing the scope will now
cascade to the connection and active links.
- Implementation of CBS authorization requests and refreshing, for non-management
links.
Event Hub Client
- Refactored use of the AMQP scope to better manage lifespan and match behavior
desired by the service team for a 1:1 correlation between connections and clients.
General
- Tweaks to some test timings, to reduce flakiness in nightly runs
- Rename of Guard -> Argument to match the refactoring done when it was moved
to Core.
- Marking several tests as flaky, pending investigation and fixes.
- Tweaking retry times for ARM activities in tests, in the lovely game of
whack-a-mole with intermittend HTTP request failures.
jsquire
force-pushed
the
eventhubs/amqp-scope
branch
from
4718f51 to
deeb3af
Compare
This was referenced Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intent of these changes is to refactor and extend the AMQP connection and link management infrastructure to support links using CBS authorization and offer creation of links for receiving events from the Event Hubs Service. Some small tweaks have also been made to help stablize tests or mark them for further investigation.
Last Upstream Rebase
Thursday, October 3, 3:11pm (EDT)
Related and Follow-Up Issues