-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Azure.Security.KeyVault.Secrets preview2 doesn't support update #7189
Comments
Looks like the link to the KeyVault Readme is changing with regard to the link for Steps to Reproduce. |
@KSchlobohm thanks for pointing this out! We'll take a look at this! |
Thanks for the feedback! The server API actually only updates secret attributes, so the value isn't part of the response, though if required to be passed in could simply be cached. We are considering what this API will look like and how it relates to the other bug about |
Addresses issues raised in Azure#7189 and Azure#7193 where the samples do not compile. These are not fixes, as we'll address the API issues in track 2 preview 4.
The client code was fixed in #7729. Will leave open to track making sure the samples are updated. |
Fixes Azure#7189 and fixes Azure#7889
Describe the bug
Following along with the documentation the process for updating a secret is shown. This process does not compile (the Secret constructor requires 2 string params) and does not succeed due to a required parameter of secret.Version which is a read-only property.
NOTE: another issue with the example is that the returned object from client.Update is of type SecretBase which does not have a "Value" property as shown in the example. This "missing property" issue also applies to the delete example in the Readme.md file.
Exception or Stack Trace
To Reproduce
Steps to reproduce the behavior:
Code Snippet
Expected behavior
Expecting to be able to set the version of the secret and receive an updatedSecret response.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):
Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
The text was updated successfully, but these errors were encountered: