Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldBuilder fails ungracefully on self-referential type #8738

Closed
brjohnstmsft opened this issue Nov 12, 2019 · 2 comments
Closed

FieldBuilder fails ungracefully on self-referential type #8738

brjohnstmsft opened this issue Nov 12, 2019 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@brjohnstmsft
Copy link
Member

When using FieldBuilder on a type with a recursive self reference, it throws StackOverflowException. Bug was reported via Stack Overflow.

Expected behavior
FieldBuilder should ignore the self-reference and return a list of fields for all the other properties of the target type.

Setup (please complete the following information):

  • Microsoft.Azure.Search 10.1.0
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 12, 2019
@brjohnstmsft brjohnstmsft self-assigned this Nov 12, 2019
@triage-new-issues triage-new-issues bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 12, 2019
@brjohnstmsft
Copy link
Member Author

FYI @AlexGhiondea Not sure if FieldBuilder will be part of the Track 2 .NET SDK GA milestone, but whenever it gets ported to Track 2, this needs to be fixed.

@AlexGhiondea AlexGhiondea added the Client This issue points to a problem in the data-plane of the library. label Feb 11, 2020
@AlexGhiondea AlexGhiondea assigned tg-msft and unassigned AlexGhiondea Feb 11, 2020
@AlexGhiondea AlexGhiondea added this to the [2020] April milestone Mar 3, 2020
@tg-msft tg-msft modified the milestones: [2020] April, [2020] June Apr 6, 2020
@tg-msft tg-msft assigned heaths and unassigned tg-msft Apr 6, 2020
@AlexGhiondea AlexGhiondea changed the title [BUG] [Azure Cognitive Search] FieldBuilder fails ungracefully on self-referential type FieldBuilder fails ungracefully on self-referential type Apr 21, 2020
@heaths
Copy link
Member

heaths commented Apr 24, 2020

Tracked as part of #11166

@heaths heaths closed this as completed Apr 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

4 participants