Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Design and implement FieldBuilder #11166

Closed
tg-msft opened this issue Apr 8, 2020 · 1 comment · Fixed by #14023
Closed

Search: Design and implement FieldBuilder #11166

tg-msft opened this issue Apr 8, 2020 · 1 comment · Fixed by #14023
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] August

Comments

@tg-msft
Copy link
Member

tg-msft commented Apr 8, 2020 •
edited by heaths
Loading

In the design, consider:
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Apr 8, 2020
@tg-msft tg-msft added this to the [2020] May milestone Apr 8, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Apr 8, 2020
Closed
26 tasks
This was referenced Apr 24, 2020
Closed
Closed
@heaths heaths modified the milestones: [2020] May, [2020] June Apr 28, 2020
@AlexGhiondea AlexGhiondea mentioned this issue May 6, 2020
Closed
17 tasks
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 27, 2020
@heaths
Define public APIs for FieldBuilder
fdc0528 
Define the public APIs for Azure#11166
@heaths heaths mentioned this issue May 27, 2020
Merged
heaths added a commit that referenced this issue May 29, 2020
@heaths
Define public APIs for FieldBuilder (#12331)
224896f 
* Define public APIs for FieldBuilder

Define the public APIs for #11166
@heaths
Copy link
Member

heaths commented Jun 3, 2020

Because of planned changes for de/serialization, we're punting this till all that's finalized enough to start this work.

@heaths heaths modified the milestones: [2020] June, [2020] August Jun 3, 2020
@heaths heaths mentioned this issue Jun 3, 2020
Closed
@heaths heaths mentioned this issue Jul 25, 2020
Closed
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Aug 6, 2020
@heaths
Initial implementation of FieldBuilder
d87e908 
Fixes Azure#11166. This is a port of the original track 1 FieldBuilder, which was merely a sample for track 2 GA.
This was referenced Aug 6, 2020
Merged
Closed
heaths added a commit that referenced this issue Aug 11, 2020
@heaths
Initial implementation of FieldBuilder (#14023)
eea50ac 
* Initial implementation of FieldBuilder

Fixes #11166. This is a port of the original track 1 FieldBuilder, which was merely a sample for track 2 GA.

* Add FieldBuilder sample

* Resolve PR feedback on code

* Conditionalize FieldBuilder implementation

* Fix recorded serializer tests

* Update public API and samples

* Add back conditional FieldBuilder sample

* Use default attribute property values for FieldBuilder

* Update to Azure.Core package reference

* Update FieldBuilder exception message with docs

Relates to #14058

* Use relative link to Sample04_FieldBuilder.md

Created new issue #14060 to track using a fully-qualified URL once this PR is merged.

* Remove reference to Microsoft.Spatial in production code

* Refocus FieldBuilder sample on FieldBuilderIgnore
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] August
2 participants
@tg-msft @heaths