Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sample04_FieldBuilder.md link in README.md #14060

Closed
heaths opened this issue Aug 8, 2020 · 0 comments · Fixed by #14135
Closed

Update Sample04_FieldBuilder.md link in README.md #14060

heaths opened this issue Aug 8, 2020 · 0 comments · Fixed by #14135
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] August

Comments

@heaths
Copy link
Member

heaths commented Aug 8, 2020

After #14023 is merged, update the link in the sdk/search/Azure.Search.Documents/samples/README.md file to use a fully-qualified URL to Sample04_FieldBuilder.md.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 8, 2020
@heaths heaths self-assigned this Aug 8, 2020
@heaths heaths added Client This issue points to a problem in the data-plane of the library. Search labels Aug 8, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 8, 2020
@heaths heaths added this to the [2020] August milestone Aug 8, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Aug 8, 2020
@heaths
Use relative link to Sample04_FieldBuilder.md
0e5ad30 
Created new issue Azure#14060 to track using a fully-qualified URL once this PR is merged.
heaths added a commit that referenced this issue Aug 11, 2020
@heaths
Initial implementation of FieldBuilder (#14023)
eea50ac 
* Initial implementation of FieldBuilder

Fixes #11166. This is a port of the original track 1 FieldBuilder, which was merely a sample for track 2 GA.

* Add FieldBuilder sample

* Resolve PR feedback on code

* Conditionalize FieldBuilder implementation

* Fix recorded serializer tests

* Update public API and samples

* Add back conditional FieldBuilder sample

* Use default attribute property values for FieldBuilder

* Update to Azure.Core package reference

* Update FieldBuilder exception message with docs

Relates to #14058

* Use relative link to Sample04_FieldBuilder.md

Created new issue #14060 to track using a fully-qualified URL once this PR is merged.

* Remove reference to Microsoft.Spatial in production code

* Refocus FieldBuilder sample on FieldBuilderIgnore
@heaths heaths mentioned this issue Aug 11, 2020
Closed
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Aug 11, 2020
@heaths
Use fully-qualified link to FieldBuilderIgnore docs
d2756b5 
Fixes Azure#14060
@heaths heaths mentioned this issue Aug 11, 2020
Merged
heaths added a commit that referenced this issue Aug 11, 2020
@heaths
Use fully-qualified link to FieldBuilderIgnore docs (#14135)
3d3d3ab 
Fixes #14060
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] August
Development

Successfully merging a pull request may close this issue.

Use fully-qualified link to FieldBuilderIgnore docs heaths/azure-sdk-for-net
1 participant
@heaths