Initial implementation of FieldBuilder #14023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Azure#11166. This is a port of the original track 1 FieldBuilder, which was merely a sample for track 2 GA.
ghost
added
the
heaths
requested review from
arv100kri,
bleroy,
chidozieononiwu,
danieljurek,
KrzysztofCwalina,
mitchdenny,
pakrym and
weshaggard
as code owners
|
@weshaggard how are we supposed to add new fully-qualified links from master when we're just adding them in a PR? Link verification failed:
This file will exist at that location once checked in. Seems link verification should somehow take that into account. For now I'll work around it by using a relative URL, but will have to open a new PR to then fix it once this is merged, which is a bit of a hassle. |
Created new issue Azure#14060 to track using a fully-qualified URL once this PR is merged.
pakrym
reviewed
Aug 10, 2020
tg-msft
approved these changes
Aug 10, 2020
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/tests/Azure.Search.Documents.Tests.csproj
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/samples/Sample04_FieldBuilder.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11166. This is a port of the original track 1 FieldBuilder, which was merely a sample for track 2 GA.
See heaths#3 for original discussion.