[Service Bus] Add message batching #10305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Core/TransportSender.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/tests/ProcessorLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/tests/SenderLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpSender.cs
Outdated
Show resolved
Hide resolved
|
I wonder if we can copy the EH unit tests in AmqpEventBatchTests |
Created an issue - #10325. Will add in a separate PR. |
JoshLove-msft
approved these changes
Mar 5, 2020
Closed
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Nov 27, 2020
Fix errors in various of readme files encountered in the recent go SDK release (Azure#11826) * Fix an issue on windows * Fix cdn * Fix cognitiveservices/customVision * Fix cognitiveservices/personalizer * Fix cognitiveservices/translatorText * Fix data plane digitaltwins * Remove problematic tag from release - no impact on sdk, this has never been released * amend Fix cognitiveservices/translatorText * Fix imds * Fix migrate readme that are mistakenly damaged in Azure#10305 * add one api-version back * Fix digtaltwins data plane again * Fix hybridnetwork * Fix streamanlytics * Revert some changes of digitaltwins * Revert imds * Fix migrate * Fix migrate again
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Nov 27, 2020
Fix errors in various of readme files encountered in the recent go SDK release (Azure#11826) * Fix an issue on windows * Fix cdn * Fix cognitiveservices/customVision * Fix cognitiveservices/personalizer * Fix cognitiveservices/translatorText * Fix data plane digitaltwins * Remove problematic tag from release - no impact on sdk, this has never been released * amend Fix cognitiveservices/translatorText * Fix imds * Fix migrate readme that are mistakenly damaged in Azure#10305 * add one api-version back * Fix digtaltwins data plane again * Fix hybridnetwork * Fix streamanlytics * Revert some changes of digitaltwins * Revert imds * Fix migrate * Fix migrate again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of these changes is to implement size-limited message batches and the means to send them to the Queue/Topic.
Goals