Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Support create container with Encryption scope #10867

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

blueww
Copy link
Member

@blueww blueww commented Mar 26, 2020

and upgrade version to 15.0.0

AutoRest information
Requested version: latest
Bootstrapper version: autorest@2.0.4413
Bootstrapper version: autorest@3.0.6187
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it is recommended not to use the latest autorest because it causes some issues in the generated code. Please update your generate.ps1 and use 2.0.4413 instead. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed, I have regenerate with 2.0.4413.
But I don't change the generate.ps1 in this PR..
Would you please help to notify us when can we switch to latest, and I will use 2.0.4413 instead of latest before that.

@isra-fel isra-fel added needs-revision Mgmt This issue is related to a management-plane library. labels Mar 27, 2020
@blueww blueww force-pushed the containeres branch 2 times, most recently from ce3781b to 1b3e644 Compare March 27, 2020 12:33
@blueww
Copy link
Member Author

blueww commented Mar 27, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10867 in repo Azure/azure-sdk-for-net

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit 9861e09 into Azure:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants