Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resources] Update .NET SDK based on swagger update of Validate API #11240

Merged
merged 3 commits into from
Apr 14, 2020
Merged

[Resources] Update .NET SDK based on swagger update of Validate API #11240

merged 3 commits into from
Apr 14, 2020

Conversation

filizt
Copy link
Contributor

@filizt filizt commented Apr 10, 2020

No description provided.

@filizt
Copy link
Contributor Author

filizt commented Apr 10, 2020 •
edited
Loading

Looking at the test failures. Update: fixed the issue. All checks passing now.

@isra-fel isra-fel self-assigned this Apr 13, 2020
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Apr 13, 2020
@filizt filizt mentioned this pull request Apr 13, 2020
Merged
5 tasks
@isra-fel
Copy link
Member

Hi @filizt , we need all SDKs to be generated basing on rest api spec on master branch, so please regenerate after the spec PR is merged.
Besides, please also write tests to cover new operations; update versions and reslease notes.
Thanks

@filizt
Copy link
Contributor Author

filizt commented Apr 14, 2020

Hi @filizt , we need all SDKs to be generated basing on rest api spec on master branch, so please regenerate after the spec PR is merged.
Besides, please also write tests to cover new operations; update versions and reslease notes.
Thanks

Swagger PR is merged and I regenerated the SDK. Versions and release notes are updated. We need this PR to be merged asap since we have a customer affecting bug in a previously released SDK. This PR is fixing that issue.

isra-fel
isra-fel approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit b57e5a5 into Azure:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

@filizt filizt

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filizt @isra-fel