[Synapse] - Build track 2 data plane SDK #12275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idear1203
requested review from
AlexGhiondea,
KrzysztofCwalina,
pakrym,
tg-msft and
mitchdenny
as code owners
|
/azp run net - synapse - tests |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
No pipelines are associated with this pull request. |
|
/azp run net - synapse - tests |
|
No pipelines are associated with this pull request. |
|
/azp run net - synapse - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
idear1203
force-pushed
the
synapse_track_2_data_plane_sdk
branch
from
8c6360c to
e7c02e2
Compare
tg-msft
approved these changes
May 30, 2020
There was a problem hiding this comment.
I am super impressed by what you have here! I've looked through every file and I have no blocking feedback. I left Nit comments on things you can change if you want, but I think this is ready to merge. I typically left feedback for common patterns once (i.e., I said don't use var in one README but it applies to them all).
Please update ApiView with this version of your APIs so we can start digging into all the individual names, etc. You have a lot of different client types and we might want to think about ways to simplify the customer experience.
Thank you!
|
|
||
| This directory contains the open source subset of the .NET SDK. For documentation of the complete Azure SDK, please see the [Microsoft Azure .NET Developer Center](http://azure.microsoft.com/en-us/develop/net/). | ||
|
|
||
| The Azure Synapse Analytics access control client library enables programmatically managing role assignments. |
There was a problem hiding this comment.
Nit - move this line to the top of this section.
| Install the Azure Synapse Analytics access control client library for .NET with [NuGet][nuget]: | ||
|
|
||
| ```PowerShell | ||
| Install-Package Azure.Analytics.Synapse.AccessControl -IncludePrerelease |
There was a problem hiding this comment.
Nit - use dotnet add package because that's more familiar than Install-Package
| ``` | ||
|
|
||
| ## Examples | ||
| The Azure.Analytics.Synapse.AccessControl package supports synchronous and asynchronous APIs. The following section covers some of the most common Azure Synapse Analytics access control related tasks: |
There was a problem hiding this comment.
Nit - maybe explain what a 'role assignment' is here since all your examples jump right into it.
There was a problem hiding this comment.
Good suggestion! Added to Key concepts section.
| `GetRoleAssignments` enumerates the role assignments in the Synapse workspace. | ||
|
|
||
| ```C# Snippet:ListRoleAssignments | ||
| var roleAssignments = client.GetRoleAssignments().Value; |
There was a problem hiding this comment.
Nit - we're leaning away from var in samples because the implicit cast (that you're working around with .Value) has been confusing to customers.
There was a problem hiding this comment.
Thanks for the info! I will remove var from both sample code and README
| @@ -0,0 +1,7 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.0-preview.1 (2020-04-01) | |||
There was a problem hiding this comment.
Nit - we typically leave the date as (Unreleased) for future versions
|
|
||
| namespace Azure.Analytics.Synapse.Artifacts | ||
| { | ||
| public partial class PipelineClient |
There was a problem hiding this comment.
We can discuss this more in ApiView, but Pipeline is such an overloaded term that we might want to think about other names for this.
There was a problem hiding this comment.
Sure. Let's talk about this in ApiView. I will update the assemblies in ApiView soon.
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
There was a problem hiding this comment.
In the past we had issues with these .shproj files building across platforms. It looks like they're building fine now and that's no longer an issue which is great.
Comment on lines
+23
to
+27
| if ("Live".Equals(Environment.GetEnvironmentVariable("AZURE_SYNAPSE_TEST_MODE"), StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| _listener = AzureEventSourceListener.CreateConsoleLogger(EventLevel.Verbose); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this something we could incorporate into our test framework?
There was a problem hiding this comment.
This is not used actually. I just follow the KeyVault file here: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/Azure.Security.KeyVault.Shared/tests/KeyVaultTestEventListener.cs.
Can we just leave it as it is until I fully understand the logic here?
There was a problem hiding this comment.
Sure. Might be worth looking at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core.TestFramework/src/TestEventListener.cs instead when you do as that's the one we're standardizing. It's fine to leave this as-is for now.
There was a problem hiding this comment.
Thanks for the info. Created a GitHub issue here to track this.
| /// <summary> | ||
| /// API version for Spark job service. | ||
| /// </summary> | ||
| public string VersionString { get; set; } |
There was a problem hiding this comment.
How is this different than ServicVersion?
There was a problem hiding this comment.
Sorry I might not get your point. The reason I want to make it public here is because I want to give users ability to set API version. It is useful in some scenarios, for example, when we can easily test a new API version in this way.
There was a problem hiding this comment.
Here's the relevant bit from our C# Guidelines
✅ DO allow the consumer to explicitly select a supported service API version when instantiating the service client.
Use a constructor parameter called version on the client options type.
- The version parameter must be the first parameter to all constructor overloads.
- The version parameter must be required, and default to the latest supported service version.
- The type of the version parameter must be ServiceVersion; an enum nested in the options type.
- The ServiceVersion enum must use explicit values starting from 1.
- ServiceVersion enum value 0 is reserved. When 0 is passed into APIs, ArgumentException should be thrown
For our Track 2 clients, we create ServiceVersion enums with all the different service versions supported by a client library. Customers can then select the specific service version using that enum when they create their ClientOptions or leave it empty to use the latest. It's easier than going to the REST docs to find the list of available version strings and it tells them exactly which subset of those versions are supported by this client library.
Generally if you need to do this for testing, we'd suggest a pipeline policy rather than a public API. Here's a quick example of using a pipeline policy to change your API version.
I think it's fine to merge your changes in and address this separately after.
There was a problem hiding this comment.
Hi @tg-msft , we do have a ServiceVersion enums . For example: in this file it is defined here.
According to the discussion, since it is possible to change API version for testing, I will change it to internal and remove the setter.
I am following the instructions here. Not sure if this is out of date. @pakrym for awareness.
| // Licensed under the MIT License. | ||
|
|
||
| using Azure.Analytics.Synapse.Spark.Models; | ||
| using Newtonsoft.Json.Linq; |
There was a problem hiding this comment.
Nit - can you use System.Text.Json instead?
idear1203
force-pushed
the
synapse_track_2_data_plane_sdk
branch
2 times, most recently
from
bcb853a to
065ada3
Compare
|
All the changes look great. I think this is ready to be merged. |
idear1203
force-pushed
the
synapse_track_2_data_plane_sdk
branch
from
2dee6d9 to
5213b13
Compare
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/check-enforcer override |
|
/azp run net - synapse - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danieljurek
added a commit
that referenced
this pull request
Jun 15, 2020
* [Storage] Add test case for accesstier (#12340) * [Datafactory] Enable Excel SDK (#12282) * Enable Excel SDK * update Co-authored-by: zhanyu2014 <zhanyu@microsoft.com> * update Azure.ClientSdk.Analyzers to 20200529.1 (#12370) * make it required (#12354) * Tables: Query support for dictionary entities and CreateFilter (#12366) * Support for dictionary entities and CreateFilter * add comment to CreateFilter * take the new Azure.ClientSdk.Analyzers and remove pragmas * remove redundant .ToList() calls in tests * make CreateFilter less prominant on the client * Initial commit to master for Azure Digital Twins .Net SDK. (#12398) * Update Batch SDK regeneration instructions (#12347) * K8sConfiguration .Net SDK - Create (#12227) * K8sConfiguration .Net SDK - Create * include k8s in CI * Project version and dependencies update Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> * Support Sku capabilities. Bump to 7.3.0 (#12328) * Support Sku capabilities. Bump to 7.3.0 * Generate from AutoRest * Removed color and imageType from the VisualFeature enum (#12375) * Removed color and imageType from the VisualFeature enum * Modified test data and removed changes to generated code (so the deprecated enum still exists in there) * Regenerated CreateSkillsetReturnsCorrectDefinitionImageAnalysisKeyPhrase.json on dogfood * Generate new .NET SDK based on #9377 (#12364) * Generate new .NET SDK based on #9377 * Update package version * [Event Hubs Client] Migration Guide Updates (#12402) The focus of these changes is to enhance the migration guide with additional information about the client hierarchy and discuss the limitations around processor types consuming legacy checkpoint data. * [FormRecognizer] Remove Operation type constructors (#12419) * Release prep (#12422) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * Release preparation * Update GitIgnore (#12368) * Enable return type and banned assembly analyzers (#12418) * Increment version for storage releases (#12423) * Increment package version after release of Azure.Storage.Common * Increment package version after release of Azure.Storage.Files.Shares * Increment package version after release of Azure.Storage.Blobs * Increment package version after release of Azure.Storage.Files.DataLake * Increment package version after release of Azure.Storage.Queues * Increment version for storage releases (#12425) * Increment package version after release of Azure.Storage.Common * Increment package version after release of Azure.Storage.Files.Shares * Increment package version after release of Azure.Storage.Blobs * Increment package version after release of Azure.Storage.Files.DataLake * Increment package version after release of Azure.Storage.Queues * feat(Samples): Add Telemetry Sample (#12407) feat(Samples): Add Telemetry Sample * add some unit tests for expression parsing (#12421) * add some unit tests for expression parsing * refactor for TestCaseSource * fixup naming * samples(adt): Update ctor snippets, and update sample options (#12409) * fix(e2e): Fix replay tests for differnt OS(s) (#12424) * fix(adt): fix BasicDigitalTwin and use in an example (#12428) * Update root readme file (#12430) * samples(adt): add a sample for using a custom twin type for serialization (#12432) * Update swagger_to_sdk_config.json (#12412) @microsoft.azure/autorest.csharp@2.3.84 is a preview version. Going back to 82 * Fix Incomplete Doc Upload (#12442) * ensure that child directory items are copied * bump template version so it can actually pass through the version checks + integration feed * Update AutoRest C# version to https://github.com/Azure/autorest.csharp/releases/download/3.0.0-dev.20200602.1/autorest-csharp-v3-3.0.0-dev.20200602.1.tgz (#12435) * Fix json serialization of geometries (#12440) * samples(adt): add snippets for get and deserialize digital twin (#12441) * fix(adt): Updated comments to generted more meaningful API documentation (#12443) * Escaping % (percent sign) segment in Uri.AppendToPath (#12369) * Escaping % percent sign in segment in AppendToPath * webdocs(adt): test seealso, and adding links for more resources (#12471) * Make collection properties read-only (#12459) * Make collection properties read-only Fixes #11712. Removes the setters per .NET guidelines. * Resolve PR feedback * feat(adt): Adding see-also section for sync methods (#12470) * comments(adt): removing inaccurate comment (#12474) * Remove FieldBuilder (#12464) * Remove FieldBuilder Resolves #12460 * Update public APIs * feat(test): Adding tests to ensure that the test mode values are not changed (#12481) * Ignore Azure.Management.KeyVault.Tests (#12483) Works around #12211 by ignoring tests that fail sporadically for both live and playback tests. * Default to more Newtonsoft-like response encoding in TestFramework (#12482) * samples(adt): misc minor clean-up from Azure SDK review (#12488) * feat(adt): Add exception tag to comments (#12475) * Add SessionReceiverOptions/SessionProcessorOptions (#12383) * Changelogs and version updates for June release (#12507) * test(PublishTelemetry): Add E2E test for Publish Telemetry API (#12479) * Increment version for core releases (#12516) * Update versions of Azure.Core and Azure.Core.Experimental (#12520) * Update AutoRest C# version (#12525) Co-authored-by: Pavel Krymets <pavel@krymets.com> * Release Prep (#12526) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * release prep * samples(adt): Update component property to be an integer (#12515) * samples(adt): Update component property to be an integer * samples(adt): Update dt property to be an integer Co-authored-by: Abhipsa Misra <abhipsa.misra@microsoft.com> * Increment version for storage releases (#12529) * Increment package version after release of Azure.Storage.Queues * Increment package version after release of Azure.Storage.Common * Increment package version after release of Azure.Storage.Files.Shares * Increment package version after release of Azure.Storage.Blobs * Increment package version after release of Azure.Storage.Files.DataLake * samples(adt): more misc changes per Azure SDK review (#12532) * feat(samples): Add an introduction section to the samples page (#12524) * Added xml dataset & fixed version issue (#12458) Co-authored-by: Shawn Xiao (IM) <shawnxia@microsoft.com> * Batch Management SDK 11.0.0 (#12393) * 2020-05-01 generated sdk and recordings * update changelog * fix description typo * undo change to changelog * update AzSdk.RP.props * update assemblyinfo * GuestConfiguration SDK update to support ARC senario (#12373) * GuestConfiguration SDK update to support ARC senario * add unit tests * add unit tests2 * [no change] trigger a new build * [no change] trigger a new build2 * migrate tests to subscription: MGMT GCRP Package Test 001, re-record the tests Co-authored-by: ge huang <gehuan@microsoft.com> * Rename AnalyzeRequest to AnalyzeTextOptions (#12489) * Rename AnalyzeRequest to AnalyzeTextOptions Fixes #12486 Fixes #12530 * Rename some properties, parameters for consistency Fixes #12536 * Removed the SynonymMap.Format property Only "solr" is supported, and this makes .NET consistent with the other languages. * Resolve PR feedback * Implement the management client (#12484) ATOM based management operations * Making developer credential types public (#12501) * Making developer credential types public * update api listing * docs(adt): add link to samples (#12533) * Increment version for extensions releases (#12547) * feat(samples): Use DefaultAzureCredential in samples using app id login (#12535) * [FormRecognizer] Preview 3: moving to new Receipt design (#12523) * Identity Adding Authenticate APIs to UsernamePasswordCredential (#12502) * Adding Authenticate APIs to UsernamePasswordCredential * updating test recordings * updating api listing * update changelog * [TA] Drop preview and change readme links to absolute (#12541) * drop preview and links absolute * updates * add azure-cognitive-services to our samples * change package version * Consistency operation failed status management in LRO (#12453) * failures in LROs * changelog * PR Feedback * don't overwrite history.... * improve race condition comment * [FR] Absolute links and bump version in Readme (#12540) * absolute links and version * add azure-cognitive-services to samples readme * Add changelog format template - bump nuget version for next release - Update nuget tag (#12552) * Update release info * refactor(adt): move QueryChargeHelper to root namespace (#12569) * Add sdk directory name check (#12556) * [Synapse] - Build track 2 data plane SDK (#12275) * [Synapse] - Build track 2 SDK * Update ci.yml * Remove unused gitignore * Resolve compilation error * Fix build error * Update README * Update code snippets and README * Update README * Add file header for code snippet * Remove template api * Rename Azure.Analytics.Synapse.Development to Azure.Analytics.Synapse.Artifacts * Re-generate to the latest Swagger spec * Regenerate with the latest code generator * Resolve comments * Make VersionString internal and remove setter * Sync up with master, consume official Swagger repo and regenerate code Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * update change log for KeyVault track 2 mgmt sdk (#12272) * update change log for KeyVault track 2 mgmt sdk * update change log * refine change log * refine code sample * update change logs for track 2 mgmt sdks for preview (#12391) * update change logs for track 2 mgmt sdks * update code sample * [App Service] Azure .NET SDK update for Powershell (#12380) * [Datafactory] Add source/sink linked service/schema linked service support for Data Flow (#12528) * SDK changes for source/sink linked service/schema LS * update * renaming operation-ids for Cluster put and patch as per guidelines (#12554) * renaming operation-ids for Cluster put and patch as per guidelines * updated the version * updated the major version to 3.0.0 * Revert "updated the major version to 3.0.0" This reverts commit f689e1a. * [Event Hubs Client] Fix Test Environment Typo (#12596) The focus of these changes is to fix a typo on the constructor of the StorageTestEnvironment, which initializes the base class with an incorrect service directory name. * Port clientside encryption to mono-dll (#12183) * Port clientside encryption to mono-dll Ported blob client-side encryption work from long-diverged branch. Was an inheritance approach, is now part of the main package internals. Ported over WindowStream from stg73base, which allows us to prematurely end streams. Removed RollingBufferStream, as uploads no longer require seekable streams as input. * Removed crypto package from ci.yml * regenerate/export-api * Ported clientside encryption for queues * Queues handles partial decryption errors. Queues now has a listener for when only some messages cannot be decrypted. these messages are filtered out of the response and sent to the listened instead. If no listener is provided, the whole fetch throws. Some PR comments addressed. * Removed nonexistent project from sln * Change in handling key resolution Clientside decryption will now either succeed or throw. Queues can redirect their throw to a listener. * Many PR comments addressed; key-substitution added * Refactors; Mocking some tests * Refactors and bug fixes * Export-API * Constant/error/assertion refactors * Refactors * Revert deletion of an api.cs file * Minor Crypto API Adjustments * Export API * Queue listener changed to events. Other minor PR feedback. * Export api * Testing for update message encryption * Minor event API adjustments * export api * fix(tests,samples)do not send modelid in component metadata (#12573) * docs(adt): update RequestOptions documentation (#12571) * [FormRecognizer] Remove <inheritdoc> from documentation (#12570) * Fix Tables access policies test and configure related methods (#12567) * fixed accesspolicies test but still errors with recordedmode * test to default, api export, and sessions Co-authored-by: Allison Kim <t-allkim@microsoft.com> * fix(samples):remove unnecessary lines from sample (#12606) * Update for Preview 3 (#12608) * [FormRecognizer] Preview 3: updating changelog * Update DigitalTwin lifecycle to use ETag and re-record (#12603) * Update changelog (#12612) * Update changelog * Updated changelogs for preview release (#12616) * Increment package version after release of Azure.Messaging.ServiceBus (#12619) * readme(adt): update readme (#12618) * Tables: Fixup diagnostic scopes (#12621) * Fixup diagnostic scopes * fix lambda scopes * fix random failure by changing from referencing helper project to contain source code directly (#12498) * Supporting specifying test run frequency (#12454) * Add RunFrequencyAttribute to support live test run frequency * remove workaround file sdk/core/service.projects * fix(comments): Fix xml comments for API surface (#12635) * Search cross-language consistency API changes (#12615) * Search cross-language consistency API changes Fixes #11162 * Add strongly typed FacetResult helpers for Search (#12620) * Add strongly typed FacetResult helpers for Search Fixes #10613. We kept this open for a long time hoping we'd be able to do something nifty using type info, but there's just not a great answer so we're stealing the Track 1 experience. * [Synapse] - Fix test failure (#12625) * Fix test failure * Correct test name * Remove Ignore annotation and use random guid * change namespace to Azure.ResourceManager for track 2 mgmt sdk (#12598) * change namespace to Azure.ResourceManager. for track 2 mgmt sdk * update readmes * update Azure.Core.All.sln * add resource group clean up policy for management test * Support node reboot features (#12641) Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> * Throw an AggregateException for Search IndexDocuments batch errors (#12630) * Throw an AggregateException for Search IndexDocuments batch errors Fixes #10594 * Add SearchModelFactory (#12626) * Add SearchModelFactory Fixes #10610 * [FormRecognizer] Remove long-running operation transform (#12652) * Adding SearchClientBuilderExtensions (#12628) * Adding SearchClientBuilderExtensions * Updating Changelog * Increment package version after release of Azure.DigitalTwins.Core (#12617) * [Event Hubs Client] Migration Guide Tweaks (#12656) The focus of these changes is to incorporate some feedback from other languages around phrasing and content for the messaging around legacy checkpoint support. * fix setup script (#12661) * Fix SearchDocument (#12610) * Fix SearchDocument * PR Feedback * PR Feedback - Change from Array to IReadOnlyList * Update README.mds for extensions (#12658) * Increment package version after release of Azure.AI.TextAnalytics (#12666) * updated mappings for new Microsoft.Web event types in the azure-sdk-for-net repo (#12171) Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> * Increment package version after release of Azure.Search.Documents (#12671) * Sync eng/common directory with azure-sdk-tools repository (#12665) * Event Grid: Regenerate new .NET SDK and record tests for new GA service API version 2020-06-01 (#12576) * regenerate .NET SDK for Event Grid 2020-06-01 API version * re-record the tests * add changelog.md and update note release * add more history to changelog.md * fix text * update version in azSdk.RP.props and assymblyinfo.cs Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com> * [Azure Cognitive Search] Creating new SDK version to match new management-plane API Version 2020-03-13 (#12607) * Generated for api 2020-03 * Removing unused dependency. * Updated session records of data plane tests. * merge upstream * Updated SDK version information. * Generated off of API Specs Master. * merge upstream * Remove unused method. * updated session record. * Skipping broken test. Co-authored-by: Jacob Hill <thhill@microsoft.com> * [Microsoft.StorageSync] Update SDK to use 2020-03-01 API version (#12560) * autorest code generation for 2020-03-01 API version * update changelog, SDK version, update tests * Updating API tag in AzSdk.props * Azure Digital Twins 0.1.0 SDK (#12538) * DigitalTwins SDK and Tests * New swagger and tests updated * enable CI * Update version Co-authored-by: Yeming Liu <felix_liu@outlook.com> Co-authored-by: Ryan Kelly <rykelly@microsoft.com> Co-authored-by: Yeming Liu <yeliu@microsoft.com> Co-authored-by: Yeming Liu <felix_liu@outlook.com> * [FormRecognizer] Changing test location to West Central US + Live tests fix (#12677) * [FormRecognizer] Preview 3: update changelogs (#12687) * Update CRUD samples (#12693) * Identity updating changelog for 1.2.0-preview.4 release (#12696) * Remove unhealthy pump (#12691) * Up version to 4.2.1 for stress testing pipeline * Remove pump if not at running or not opening states. * enable apicompat (#12669) * Increment package version after release of Azure.Identity (#12697) * Increment package version after release of Azure.AI.FormRecognizer (#12698) * [Event Hubs Client] Documentation Updates (#12690) The focus of these changes is to refine some documentation to correct a missed update to `Azure.Identity` types and improve context around storage expectations when creating an `EventProcessorClient`. * Increase Key Vault test timeout to 120mins (#12700) * Increase Key Vault test timeout to 90mins * Further increase timeout * Update sample readmes to have absolute links to GitHub (#12568) * Network SDK release for API version 2020-05-01 (#12685) * Re-generate Network SDK * fix sdk breaking change with firewall policy rule collection group rename (#12381) * Update generated code * SDK * Update SDK code * Re-generate Network SDK * Update ChangeLog * Update SDK version as 20.0.0-preview already exists Co-authored-by: gimotwanMSFT <36463144+gimotwanMSFT@users.noreply.github.com> * DiskRp changes for 2020-05-01 (#12553) * DiskRP sdk changes for api version 2020-05-01 * changing sdk versions * taking in latest changes from swagger pr * fix tests and generate sdk from latest swagger * taking in latest swagger changes and running the failed test * regenerate sdk from merged swagger * fixing autorest, updating azsdk.props, updating validation in des tests * CRR update (#12650) * CRR update * Update * ADT C# SDK Samples Improvements (#12683) * fix(samples): improve on the snippet comments * Create a relationship samples * Initial AccessControlClient for Azure.Security.KeyVault.Administration (#12480) * poc of generated client * cleanup * implement the rest * export api * tests * recorded tests * regen client * fix version * xml comments * pr comments * pr comments * diagnostic scopes * model factory * adjust diagnostic scopes * change assignment name to Guid * make RoleAssignmentListResult internal * rename file * pr comments * remove commented shared import * add xml docs for ArgumentNullExceptions * refactor(samples): Refactor the delete digital twin sample snippet (#12716) * Update AutoRest C# version (#12692) Co-authored-by: Shivangi Reja <shreja@microsoft.com> * Generate API (#12720) * Add initial samples for review (#12664) * init samples * learning about clieeents * CreateTable should work * Sample template finished with create + delete table working * first sample files * added delete nonexistent table * revised based on feedback + first readme * revised sample1 readme and file Co-authored-by: Allison Kim <t-allkim@microsoft.com> * Refresh generated code for KVAdmin library (#12725) * Simplify delete relationship snippet (#12717) * simplify delete relationship snippet * Api compat changes (#12703) * Update how ApiCompat checks are ran - Now include the ApiCompatVersion in the project - Update the ApiCompatVersion everytime we ship a GA - Remove EnableApiCompat as to disable now remove the ApiCompatVersion * Remove EnableApiCompat from everywhere. * Add ApiCompatVersion to all GA packages * PR feedback Fix bad appconfig test Add ApiCompatVersion for textanalytics * Remove apicompat project from solutions * Remove more EnableApiCompat properties * Add reboot parameters for multiple replicas per master. (#12712) * Add reboot parameters for multiple replicas per master. * Update the preview version in csproj. * Reenable registered server tests, update recordings (#12724) * Update AutoRest C# version (#12739) Co-authored-by: Pavel Krymets <pavel@krymets.com> * Fix links in extensions README.mds (#12689) * doc(adt): update prereq readme instructions (#12743) * Sanitize json body (#12707) * sanitize body * PR feedback * update to master * no var * Use US sovereign region * Use sovereign KV domain suffix * Update KV tests.yml to use new approach * Unique naming of jobs * Unique display names * Set SubscriptionConfiguraiton back to default * Name Job directly * use valid characters for job name * Parameterize KV SKU and adjust Azure China Cloud deployment * add AZURE_AUTHORITY_HOST Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: yuzhangyi <44692931+yuzhangyi@users.noreply.github.com> Co-authored-by: zhanyu2014 <zhanyu@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Azad Abbasi <azabbasi@microsoft.com> Co-authored-by: Jacob Freck <jafreck@microsoft.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com> Co-authored-by: Jennifer Marsman <jennifermarsman@users.noreply.github.com> Co-authored-by: Junbo Wang <juniwang@microsoft.com> Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: kinelski <camaiaor@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Basel Rustum <barustum@microsoft.com> Co-authored-by: David R. Williamson <drwill@microsoft.com> Co-authored-by: vinagesh <vinagesh@outlook.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Abhipsa Misra <22563986+abhipsaMisra@users.noreply.github.com> Co-authored-by: Abhipsa Misra <abhipsa.misra@microsoft.com> Co-authored-by: shawnxzq <zhiqiang.xiao@gmail.com> Co-authored-by: Shawn Xiao (IM) <shawnxia@microsoft.com> Co-authored-by: Ge Huang <gehuang.dut@gmail.com> Co-authored-by: ge huang <gehuan@microsoft.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Scott Schaab <sschaab@microsoft.com> Co-authored-by: Dongwei Wang <bean0idear@163.com> Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> Co-authored-by: erich-wang <eriwan@microsoft.com> Co-authored-by: Shubham Dhond <sdhond.sd@gmail.com> Co-authored-by: Richard Zhang <rizh@microsoft.com> Co-authored-by: Ajit Navasare <v-ajnav@microsoft.com> Co-authored-by: James <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: Allison Kim <am.kim327@gmail.com> Co-authored-by: Allison Kim <t-allkim@microsoft.com> Co-authored-by: tg-msft <tg-msft@users.noreply.github.com> Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: Paviya (Elle) Tojaroon <elle.tojaroon@gmail.com> Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> Co-authored-by: Ashraf Hamad <ahamad-MS@users.noreply.github.com> Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com> Co-authored-by: Jacob Hill <tjhill_94@hotmail.com> Co-authored-by: Jacob Hill <thhill@microsoft.com> Co-authored-by: Andre Pinto <31374863+anpint@users.noreply.github.com> Co-authored-by: Ryan K <ryan.k@outlook.com> Co-authored-by: Ryan Kelly <rykelly@microsoft.com> Co-authored-by: Yeming Liu <yeliu@microsoft.com> Co-authored-by: Yeming Liu <felix_liu@outlook.com> Co-authored-by: Serkant Karaca <serkantkaraca@users.noreply.github.com> Co-authored-by: Anton Evseev <v-anevse@microsoft.com> Co-authored-by: gimotwanMSFT <36463144+gimotwanMSFT@users.noreply.github.com> Co-authored-by: chetmaddula <57730350+chetmaddula@users.noreply.github.com> Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com> Co-authored-by: Shivangi Reja <shreja@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Lakshmi Priya Sekar <Priya91@users.noreply.github.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Jan 12, 2021
Added move validation enum values & fix S360 linting issues (Azure#12275) * Added new move product validation error codes * Added integer formats to fix S360 swagger lint validation * Fixed ModelValidation errors for v2018-11-01-preview Co-authored-by: Braden Watkins <brwatkin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to add the following 3 client libraries for Synapse:
Most code is generated based on track 2 code generator. While we are still working on board review, we would like to build and release SDK packages in order to unblock our customers.