Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Readmes #14029

Merged
merged 5 commits into from
Aug 8, 2020
Merged

Sample Readmes #14029

merged 5 commits into from
Aug 8, 2020

Conversation

meanjeekim
Copy link
Contributor

#13865

  • Revised sample snippets
  • Wrote readmes for
    • Create/Delete Entities
    • Query Tables
    • Query Entities

Looking at other samples, I might take out some of the redundant comments that are already said in the Readme itself. :P

@meanjeekim meanjeekim added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 7, 2020
@meanjeekim meanjeekim requested a review from maririos August 7, 2020 04:11
@meanjeekim meanjeekim requested a review from christothes as a code owner August 7, 2020 04:11
@meanjeekim meanjeekim self-assigned this Aug 7, 2020
@@ -0,0 +1,95 @@
# Create and Delete Entities
This sample demonstrates how to add and delete entities. To get started, you'll need access to either a Storage or Cosmos DB account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say add and delete entities to a table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure if I should go ahead and do that since the current SDK has CreateEntity as the way to add the entity to the service, but I thiiink it's supposed to change based on Krzysztof's feedback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh.. didn't know that. you could leave it as is, and whenever the new implementation comes, someone can change it

Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments here and there but overall LGTM!

@meanjeekim meanjeekim merged commit b0b06db into Azure:master Aug 8, 2020
@meanjeekim meanjeekim deleted the readmes branch August 8, 2020 02:08
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Apr 22, 2021
automanage readme t1 del (Azure#14029)

* automanage readme t1 del

* automanage readme t1 del

* readme.md t1 config del
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants