Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventGrid] Light copy editing of README.md #15417

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

ellismg
Copy link
Member

@ellismg ellismg commented Sep 24, 2020

Fixes #15304

@ghost ghost added the Event Grid label Sep 24, 2020
@ellismg
Copy link
Member Author

ellismg commented Sep 24, 2020

Pointing at the src folder instead of the root for the source code seemed to be what some other packages did, but I can understand the argument about what we currently have.

I wavered a little about the "a HTTP" vs "an HTTP", from some light reading, it seemed like it depending on how someone says "HTTP" (since a vs an is about a relation to a vowel sound).

Your call here, @JoshLove-msft, I figured I'd just save you some time and open a PR to fix the issues from #15304

@ellismg ellismg merged commit 45fa771 into Azure:master Sep 24, 2020
@ellismg ellismg deleted the ellismg/fix-15304 branch September 24, 2020 19:05
chidozieononiwu pushed a commit to chidozieononiwu/azure-sdk-for-net that referenced this pull request Sep 24, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Aug 2, 2021
[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-08-01 (Azure#15417)

* Adds base for updating Microsoft.Cache from version stable/2021-03-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Breaking Change: Replaced 'sasUri' import parameter with 'sasUris' to enable importing from multiple files

* Fix ModelValidation errors and some existing Linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure.Messaging.EventGrid Readme issues
2 participants