Added ability to set Position on streams created with OpenRead() #16083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
Comment on lines
+1509
to
+1517
| [Test] | ||
| // lower position within _buffer | ||
| [TestCase(400)] | ||
| // higher positiuon within _buffer | ||
| [TestCase(500)] | ||
| // lower position below _buffer | ||
| [TestCase(250)] | ||
| // higher position above _buffer | ||
| [TestCase(550)] |
There was a problem hiding this comment.
Should we add test cases for what happens if we go out of bound ?
There was a problem hiding this comment.
Will do before I merge.
There was a problem hiding this comment.
Actually we already have Seek() tests for these cases, and we are just calling into Seek(). I don't think it is necessary.
kasobol-msft
approved these changes
Oct 27, 2020
amnguye
approved these changes
Oct 27, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16055