Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Make modelname as a default parameter #16381

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

maririos
Copy link
Member

From arch board feedback, moving ModelName out of options bag for training and composedModel endpoints and add it as a default parameter.
documentation and tests updated

Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maririos maririos merged commit d94b537 into Azure:master Oct 29, 2020
@maririos maririos deleted the archboard branch February 8, 2021 19:58
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* model name

* include changelog

* remove unnecessary check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants