-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetricsAdvisor] Added tests.yml file for automated test runs #17894
Conversation
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/MetricsAdvisorTestEnvironment.cs
Show resolved
Hide resolved
It seems we're getting
azure-sdk-for-net/sdk/metricsadvisor/tests.yml Lines 7 to 20 in afe625a
Edit: problem solved. We just needed to add quotes to the string env vars. |
@kinelski - I'm behind on the context here. Can we not use dynamic resources for these live tests? Also, .NET tests should not use a metrics advisor account name that starts with For example in the future (assuming we need static resources), if someone on the engineering system or JS team sees an account called cc @benbp |
@danieljurek We fixed the issue. We were only missing quotes in the env vars declarations (fixed here #17910).
Unfortunately this is not feasible in Metrics Advisor. The service takes too long to create the resource (30 minutes or so). Also, once the resource is created, it still needs an indefinite amount of time to process the data we need to request in our tests.
The service limits the amount of resources we can create per subscription (only 2, if I'm not mistaken), so all languages are using the same resource for testing. It has the |
Thanks for that info! This all makes sense. :) Please track the work to fix this in a bug so it doesn't get lost. |
Tracking it here: #17918 |
Part of #15924.